[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

            Bug ID: 110677
           Summary: Can't invert screen colors by adjusting the gamma ramp
           Product: DRI
           Version: XOrg git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: vladzzag@gmail.com

On X11, there are several ways KWin can invert screen colors: either by using
an OpenGL-based effect, or by adjusting the gamma ramp. While the former
approach works well on most hardware, we experience some issues with the latter
approach on AMD hardware.

After adjusting the gamma ramp, the screen is filled with mostly white color.

Steps to reproduce:
* Open System Settings, go to Shortcuts, select KWin component under Global
Shortcuts tab, assign custom shortcut to "Invert Screen Colors";
* Press the shortcut.

(or just use xcalib -i)

Observed results:
The screen is filled with mostly white color.

Expected results:
Inverted screen.

Hardware: Radeon RX 580
Mesa: 19.0.3
Linux: 5.0.13
xorg: 1.20.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2599 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

--- Comment #1 from Vlad Zagorodniy <vladzzag@gmail.com> ---
Created attachment 144265
  --> https://bugs.freedesktop.org/attachment.cgi?id=144265&action=edit
observed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1208 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

--- Comment #2 from Vlad Zagorodniy <vladzzag@gmail.com> ---
Created attachment 144266
  --> https://bugs.freedesktop.org/attachment.cgi?id=144266&action=edit
expected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1208 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 327 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

--- Comment #3 from Vlad Zagorodniy <vladzzag@gmail.com> ---
Created attachment 144267
  --> https://bugs.freedesktop.org/attachment.cgi?id=144267&action=edit
Screen without inverted colors

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1274 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

Vlad Zagorodniy <vladzzag@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|All                         |Linux (All)
           Hardware|Other                       |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1247 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 521 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicholas.kazlauskas@amd.com

--- Comment #4 from Michel Dänzer <michel@daenzer.net> ---
Please attach the corresponding dmesg output and Xorg log file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1867 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

--- Comment #5 from Vlad Zagorodniy <vladzzag@gmail.com> ---
Created attachment 144268
  --> https://bugs.freedesktop.org/attachment.cgi?id=144268&action=edit
dmesg output

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1220 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 310 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

--- Comment #6 from Vlad Zagorodniy <vladzzag@gmail.com> ---
Created attachment 144269
  --> https://bugs.freedesktop.org/attachment.cgi?id=144269&action=edit
Xorg log file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1223 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 847 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

--- Comment #7 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
The issue is in the display driver.

The driver does an sRGB degamma, CTM, then sRGB regamma + user regamma - which
explains why the screen is mostly white (since the curve is inverse).

If the the degamma block was put into linear bypass and the user regamma was
applied directly to the regamma block that should give the correct result.

Not sure if mapping the legacy gamma to the full LUT would break any IGT color
or standard X11 gamma operations.

I do have some changes that fix this kind of operation for atomic userspace but
I'd have to take a look at the legacy one again to know if this is easy to
support or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1655 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 427 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144269|text/x-log                  |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1099 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110677] Can't invert screen colors by adjusting the gamma ramp

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110677

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #8 from Martin Peres <martin.peres@free.fr> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/783.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2386 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel