dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)
Date: Fri, 14 Jun 2019 15:11:52 +0000	[thread overview]
Message-ID: <bug-110897-502-0LmyXl4CD3@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-110897-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 2032 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110897

--- Comment #31 from Richard Thier <u9vata@gmail.com> ---
Created attachment 144545
  --> https://bugs.freedesktop.org/attachment.cgi?id=144545&action=edit
Really no cmask ram it seems

I have faked to have hiz ram and cmask ram just to see what happens.
When I am turning on MSAA now I get this glitches from the shared screenshot so
I guess it is right that my card is just not having CMASK_RAM.

  122     case CHIP_RS480:
  123         caps->zmask_ram = RV3xx_ZMASK_SIZE;
  124         caps->has_cmask = TRUE; /* guessed because there is also HiZ */
  125         caps->hiz_ram = R300_HIZ_LIMIT;
  126         break;

hiz_ram faking seems to have no effect whatsoever.

I have also tried this hack - but it did not help:

diff --git a/src/gallium/drivers/r300/r300_emit.c
b/src/gallium/drivers/r300/r300_emit.c
index 80c959b95d0..48fafecfdda 100644
--- a/src/gallium/drivers/r300/r300_emit.c
+++ b/src/gallium/drivers/r300/r300_emit.c
@@ -1224,6 +1224,10 @@ void r300_emit_hiz_clear(struct r300_context *r300,
unsigned size, void *state)
     tex = r300_resource(fb->zsbuf->texture);

     BEGIN_CS(size);
+    // FIXME: Remove this hack!
+    OUT_CS_REG(R300_ZB_ZCACHE_CTLSTAT,
+        R300_ZB_ZCACHE_CTLSTAT_ZC_FLUSH_FLUSH_AND_FREE |
+        R300_ZB_ZCACHE_CTLSTAT_ZC_FREE_FREE);
     OUT_CS_PKT3(R300_PACKET3_3D_CLEAR_HIZ, 2);
     OUT_CS(0);
     OUT_CS(tex->tex.hiz_dwords[fb->zsbuf->u.tex.level]);
@@ -1246,6 +1250,9 @@ void r300_emit_zmask_clear(struct r300_context *r300,
unsigned size, void *state
     tex = r300_resource(fb->zsbuf->texture);

     BEGIN_CS(size);
+    OUT_CS_REG(R300_ZB_ZCACHE_CTLSTAT,
+        R300_ZB_ZCACHE_CTLSTAT_ZC_FLUSH_FLUSH_AND_FREE |
+        R300_ZB_ZCACHE_CTLSTAT_ZC_FREE_FREE);
     OUT_CS_PKT3(R300_PACKET3_3D_CLEAR_ZMASK, 2);
     OUT_CS(0);
     OUT_CS(tex->tex.zmask_dwords[fb->zsbuf->u.tex.level]);

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3063 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-06-14 15:11 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 18:03 [Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?) bugzilla-daemon
2019-06-11 18:07 ` bugzilla-daemon
2019-06-11 18:18 ` bugzilla-daemon
2019-06-11 23:21 ` bugzilla-daemon
2019-06-11 23:26 ` bugzilla-daemon
2019-06-11 23:56 ` bugzilla-daemon
2019-06-12  0:43 ` bugzilla-daemon
2019-06-12  0:54 ` bugzilla-daemon
2019-06-12  1:13 ` bugzilla-daemon
2019-06-12  1:22 ` bugzilla-daemon
2019-06-12 17:33 ` bugzilla-daemon
2019-06-12 17:51 ` bugzilla-daemon
2019-06-12 20:18 ` bugzilla-daemon
2019-06-12 20:55 ` bugzilla-daemon
2019-06-12 21:04 ` bugzilla-daemon
2019-06-13  8:56 ` bugzilla-daemon
2019-06-13  9:00 ` bugzilla-daemon
2019-06-13 10:16 ` bugzilla-daemon
2019-06-13 11:20 ` bugzilla-daemon
2019-06-13 11:21 ` bugzilla-daemon
2019-06-13 12:32 ` bugzilla-daemon
2019-06-13 12:35 ` bugzilla-daemon
2019-06-13 15:35 ` bugzilla-daemon
2019-06-13 15:38 ` bugzilla-daemon
2019-06-13 15:38 ` bugzilla-daemon
2019-06-13 20:07 ` bugzilla-daemon
2019-06-13 23:18 ` bugzilla-daemon
2019-06-13 23:37 ` bugzilla-daemon
2019-06-14 12:06 ` bugzilla-daemon
2019-06-14 12:28 ` bugzilla-daemon
2019-06-14 12:28 ` bugzilla-daemon
2019-06-14 12:52 ` bugzilla-daemon
2019-06-14 13:20 ` bugzilla-daemon
2019-06-14 15:00 ` bugzilla-daemon
2019-06-14 15:11 ` bugzilla-daemon [this message]
2019-06-14 15:30 ` bugzilla-daemon
2019-06-14 17:20 ` bugzilla-daemon
2019-06-14 17:26 ` bugzilla-daemon
2019-06-14 21:44 ` bugzilla-daemon
2019-06-14 22:01 ` bugzilla-daemon
2019-06-14 22:11 ` bugzilla-daemon
2019-06-14 23:05 ` bugzilla-daemon
2019-06-14 23:09 ` bugzilla-daemon
2019-06-14 23:10 ` bugzilla-daemon
2019-06-14 23:20 ` bugzilla-daemon
2019-06-14 23:30 ` bugzilla-daemon
2019-06-15  1:23 ` bugzilla-daemon
2019-06-15  1:27 ` bugzilla-daemon
2019-06-15  2:31 ` bugzilla-daemon
2019-06-15 13:27 ` bugzilla-daemon
2019-06-15 15:15 ` bugzilla-daemon
2019-06-15 15:20 ` bugzilla-daemon
2019-06-15 17:39 ` bugzilla-daemon
2019-06-15 17:40 ` bugzilla-daemon
2019-06-15 17:45 ` bugzilla-daemon
2019-06-15 21:48 ` bugzilla-daemon
2019-06-15 22:10 ` bugzilla-daemon
2019-06-16  9:05 ` bugzilla-daemon
2019-06-16 11:21 ` bugzilla-daemon
2019-06-16 11:23 ` bugzilla-daemon
2019-06-16 14:17 ` bugzilla-daemon
2019-06-16 15:44 ` bugzilla-daemon
2019-06-16 15:47 ` bugzilla-daemon
2019-06-16 17:22 ` bugzilla-daemon
2019-06-16 17:41 ` bugzilla-daemon
2019-06-16 20:16 ` bugzilla-daemon
2019-06-16 20:49 ` bugzilla-daemon
2019-06-16 23:24 ` bugzilla-daemon
2019-06-17  6:19 ` bugzilla-daemon
2019-06-17  9:22 ` bugzilla-daemon
2019-06-17 18:30 ` bugzilla-daemon
2019-06-17 19:40 ` bugzilla-daemon
2019-06-17 20:49 ` bugzilla-daemon
2019-06-17 21:48 ` bugzilla-daemon
2019-06-19  3:07 ` bugzilla-daemon
2019-09-18 18:55 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110897-502-0LmyXl4CD3@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox