From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?) Date: Fri, 14 Jun 2019 12:52:13 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0827437660==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id C18EE892B1 for ; Fri, 14 Jun 2019 12:52:12 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0827437660== Content-Type: multipart/alternative; boundary="15605167320.12b5ea1.1616" Content-Transfer-Encoding: 7bit --15605167320.12b5ea1.1616 Date: Fri, 14 Jun 2019 12:52:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110897 --- Comment #28 from Richard Thier --- I still see the glitches with the following changes: @@ -364,11 +369,21 @@ static void r300_clear(struct pipe_context* pipe, /* Clear. */ if (buffers) { /* Clear using the blitter. */ + + /* FIXME: Twoline HACKZ TO SAVE FLAGS THAT blitter_clear clears */ + bool tmp_zmask_clear_dirty =3D r300->zmask_clear.dirty; + bool tmp_hiz_clear_dirty =3D r300->hiz_clear.dirty; + r300_blitter_begin(r300, R300_CLEAR); util_blitter_clear(r300->blitter, width, height, 1, buffers, color, depth, stencil); + /* FIXME: two lines of hack! */ + r300->zmask_clear.dirty =3D tmp_zmask_clear_dirty; + r300->hiz_clear.dirty =3D tmp_hiz_clear_dirty; + r300_blitter_end(r300); - } else if (r300->zmask_clear.dirty || +/* TIPP: here maybe not else if, just an if should be present??? */ + } /*else*/ if (r300->zmask_clear.dirty || r300->hiz_clear.dirty || r300->cmask_clear.dirty) { Even though we are now entering the things after this if and go where the z= ram clear emit is. Maybe this is not the problem... --=20 You are receiving this mail because: You are the assignee for the bug.= --15605167320.12b5ea1.1616 Date: Fri, 14 Jun 2019 12:52:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 28 on bug 11089= 7 from = Richard Thier 
I still see the glitches with the following changes:

@@ -364,11 +369,21 @@ static void r300_clear(struct pipe_co=
ntext* pipe,
     /* Clear. */
     if (buffers) {
         /* Clear using the blitter. */
+
+        /* FIXME: Twoline HACKZ TO SAVE FLAGS THAT blitter_clear clears */
+        bool tmp_zmask_clear_dirty =3D r300->zmask_clear.dirty;
+       bool tmp_hiz_clear_dirty =3D r300->hiz_clear.dirty;
+
         r300_blitter_begin(r300, R300_CLEAR);
         util_blitter_clear(r300->blitter, width, height, 1,
                            buffers, color, depth, stencil);
+       /* FIXME: two lines of hack! */
+       r300->zmask_clear.dirty =3D tmp_zmask_clear_dirty;
+       r300->hiz_clear.dirty =3D tmp_hiz_clear_dirty;
+
         r300_blitter_end(r300);
-    } else if (r300->zmask_clear.dirty ||
+/* TIPP: here maybe not else if, just an if should be present??? */
+    } /*else*/ if (r300->zmask_clear.dirty ||
                    r300->hiz_clear.dirty ||
                    r300->cmask_clear.dirty) {


Even though we are now entering the things after this if and go where the z=
ram
clear emit is. Maybe this is not the problem...

You are receiving this mail because:
  • You are the assignee for the bug.
= --15605167320.12b5ea1.1616-- --===============0827437660== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0827437660==--