From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?) Date: Sun, 16 Jun 2019 17:41:38 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0085892280==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 2875A8911F for ; Sun, 16 Jun 2019 17:41:38 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0085892280== Content-Type: multipart/alternative; boundary="15607068981.74B2C.5241" Content-Transfer-Encoding: 7bit --15607068981.74B2C.5241 Date: Sun, 16 Jun 2019 17:41:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110897 --- Comment #61 from Richard Thier --- Created attachment 144560 --> https://bugs.freedesktop.org/attachment.cgi?id=3D144560&action=3Dedit Fix variant 2 (special case pipe number for 0x5a62) Added the second fix variation I've imagined. I am still compiling this so = it is not tested yet, but this should work just as well. After thinking about it now, actually I tend to favor this latter one as be= ing more clean, because I have no idea what the other rs400 cards do if I just forward to the r300 init code. My card works with that variant, but this is more sane maybe? The bad thing is that this literally only fixes those cards that do have 0x= 5a62 as their rdev->pdev->device value. So "Fix variant 1" might fix more cards if they have a similar issue and "F= ix variant 2" should fix only this one and should not break unrelated cards. --=20 You are receiving this mail because: You are the assignee for the bug.= --15607068981.74B2C.5241 Date: Sun, 16 Jun 2019 17:41:38 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 61 on bug 11089= 7 from = Richard Thier

Created attachment 144560 [details] [review]
Fix variant 2 (special case pipe number for 0x5a62)

Added the second fix variation I've imagined. I am still compiling this so =
it
is not tested yet, but this should work just as well.

After thinking about it now, actually I tend to favor this latter one as be=
ing
more clean, because I have no idea what the other rs400 cards do if I just
forward to the r300 init code. My card works with that variant, but this is
more sane maybe?

The bad thing is that this literally only fixes those cards that do have 0x=
5a62
as their rdev->pdev->device value.

So "Fix variant 1" might fix more cards if they have a similar is=
sue and "Fix
variant 2" should fix only this one and should not break unrelated car=
ds.

You are receiving this mail because:

You are the assignee for the bug.

= --15607068981.74B2C.5241-- --===============0085892280== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0085892280==--