From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?) Date: Fri, 14 Jun 2019 23:30:39 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0340472079==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 60ABB895C8 for ; Fri, 14 Jun 2019 23:30:39 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0340472079== Content-Type: multipart/alternative; boundary="15605550392.ff412.7691" Content-Transfer-Encoding: 7bit --15605550392.ff412.7691 Date: Fri, 14 Jun 2019 23:30:39 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110897 --- Comment #42 from Richard Thier --- (In reply to Marek Ol=C5=A1=C3=A1k from comment #40) > I'm afraid nobody remembers anymore how HyperZ works on r300. I can answer > basic questions if you have any. Hi! Currently I have added this to radeon_drm_winsys.c: 385 if (ws->gen =3D=3D DRV_R300) { 386 if (!radeon_get_drm_value(ws->fd, RADEON_INFO_NUM_GB_PIPES, 387 "GB pipe count", 388 &ws->info.r300_num_gb_pipes)) 389 return false; 390 + // FIXME: only works for my own setup (prenex): 391 + ws->info.r300_num_gb_pipes=3D1; Now I have no problems so far. It can be that HyperZ code is just good as-i= s, but for some resoun the radeon_get_drm_value returns a bad gb_pipes number. Currently testing with this a bit more throughly before moving further, but everything seems to work so far, just this is not a proper fix. Some questions I can have: 1.) Is there any way to ensure how many pipes a card has? One pipeline seem= s to be really few for a GPU, but this is a mobile integrated card. 2.) Can the other indicated pipes be existing on my card but turned off for some reason? 3.) radeon_get_drm_value - is this in the kernel source tree? I will have a look later on the code behind it. --=20 You are receiving this mail because: You are the assignee for the bug.= --15605550392.ff412.7691 Date: Fri, 14 Jun 2019 23:30:39 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 42 on bug 11089= 7 from = Richard Thier
(In reply to Marek Ol=C5=A1=C3=A1k from comment #40)
> I'm afraid nobody remembers anymore how HyperZ w=
orks on r300. I can answer
> basic questions if you have any.

Hi!

Currently I have added this to radeon_drm_winsys.c:

385     if (ws->gen =3D=3D DRV_R300) {
386         if (!radeon_get_drm_value(ws->fd, RADEON_INFO_NUM_GB_PIPES,
387                                   "GB pipe count",
388                                   &ws->info.r300_num_gb_pipes))
389             return false;
390 +       // FIXME: only works for my own setup (prenex):
391 +       ws->info.r300_num_gb_pipes=3D1;

Now I have no problems so far. It can be that HyperZ code is just good as-i=
s,
but for some resoun the radeon_get_drm_value returns a bad gb_pipes number.

Currently testing with this a bit more throughly before moving further, but
everything seems to work so far, just this is not a proper fix.

Some questions I can have:

1.) Is there any way to ensure how many pipes a card has? One pipeline seem=
s to
be really few for a GPU, but this is a mobile integrated card.

2.) Can the other indicated pipes be existing on my card but turned off for
some reason?

3.) radeon_get_drm_value - is this in the kernel source tree? I will have a
look later on the code behind it.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15605550392.ff412.7691-- --===============0340472079== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0340472079==--