From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 111506] [amdgpu] VRR/Freesync below the range (LFC) flickering (5700 XT) Date: Wed, 28 Aug 2019 08:26:53 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0177898310==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DA2F898F3 for ; Wed, 28 Aug 2019 08:26:53 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0177898310== Content-Type: multipart/alternative; boundary="15669808130.37fc07.14271" Content-Transfer-Encoding: 7bit --15669808130.37fc07.14271 Date: Wed, 28 Aug 2019 08:26:53 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D111506 Bug ID: 111506 Summary: [amdgpu] VRR/Freesync below the range (LFC) flickering (5700 XT) Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: not set Priority: not set Component: DRM/AMDgpu Assignee: dri-devel@lists.freedesktop.org Reporter: asheldon55@gmail.com I'm getting heavy flickering when dropping below the minimum refresh rate (default of 40-92, but I also tested 35-92) with Freesync enabled. It seems to be LFC related as the higher the minimum, the earlier the flickering kicks in (so it's not a case of the monitor not being able to ha= ndle it at the low end). I can workaround the problem by changing block of code in freesync.c: if (in_out_vrr->max_refresh_in_uhz < (2 * in_out_vrr->min_refresh_in_uhz)) in_out_vrr->btr.btr_enabled =3D false; with: if (in_out_vrr->max_refresh_in_uhz < (3 * in_out_vrr->min_refresh_in_uhz)) in_out_vrr->btr.btr_enabled =3D false; effectively forcing LFC to only kick in at ~30fps or lower.=20 It's possibly a regression as I don't remember the issue occurring with Veg= a or Polaris and 5.2 kernel. It's also possible that it's the monitor itself at fault, and maybe LFC wasn't kicking in properly in older kernels/hardware, effectively hiding the problem. I will try to get around to testing with Ve= ga and an older kernel in the future. System: MSI 5700 XT amd-staging-drm-next Mesa git --=20 You are receiving this mail because: You are the assignee for the bug.= --15669808130.37fc07.14271 Date: Wed, 28 Aug 2019 08:26:53 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 111506
Summary [amdgpu] VRR/Freesync below the range (LFC) flickering (5700 = XT)
Product DRI
Version DRI git
Hardware x86-64 (AMD64)
OS Linux (All)
Status NEW
Severity not set
Priority not set
Component DRM/AMDgpu
Assignee dri-devel@lists.freedesktop.org
Reporter asheldon55@gmail.com

I'm getting heavy flickering when dropping below the minimum r=
efresh rate
(default of 40-92, but I also tested 35-92) with Freesync enabled.

It seems to be LFC related as the higher the minimum, the earlier the
flickering kicks in (so it's not a case of the monitor not being able to ha=
ndle
it at the low end).

I can workaround the problem by changing block of code in freesync.c:

if (in_out_vrr->max_refresh_in_uhz <
            (2 * in_out_vrr->min_refresh_in_uhz))
                in_out_vrr->btr.btr_enabled =3D false;

with:

if (in_out_vrr->max_refresh_in_uhz <
            (3 * in_out_vrr->min_refresh_in_uhz))
                in_out_vrr->btr.btr_enabled =3D false;

effectively forcing LFC to only kick in at ~30fps or lower.=20

It's possibly a regression as I don't remember the issue occurring with Veg=
a or
Polaris and 5.2 kernel. It's also possible that it's the monitor itself at
fault, and maybe LFC wasn't kicking in properly in older kernels/hardware,
effectively hiding the problem. I will try to get around to testing with Ve=
ga
and an older kernel in the future.


System:
MSI 5700 XT
amd-staging-drm-next
Mesa git


You are receiving this mail because:
  • You are the assignee for the bug.
= --15669808130.37fc07.14271-- --===============0177898310== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0177898310==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 111506] [amdgpu] VRR/Freesync below the range (LFC) flickering (5700 XT) Date: Wed, 28 Aug 2019 08:42:35 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1175010455==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id E940B8995F for ; Wed, 28 Aug 2019 08:42:34 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1175010455== Content-Type: multipart/alternative; boundary="15669817541.aCDe27c4f.16919" Content-Transfer-Encoding: 7bit --15669817541.aCDe27c4f.16919 Date: Wed, 28 Aug 2019 08:42:34 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D111506 --- Comment #1 from Andrew Sheldon --- I should note that it doesn't flicker at all with the modification I sugges= ted. Presumably, LFC is in fact kicking in at 30fps and below, so assuming that's the case, it's not really LFC in general that is the problem, just LFC when just below the minimum.=20 One possibility is that LFC is somehow generating frames at a rate above the maximum refresh rate for framerates above 30 and below the minimum (35), si= nce the range is fairly narrow. Maybe it's tripling rather than doubling the framerate? --=20 You are receiving this mail because: You are the assignee for the bug.= --15669817541.aCDe27c4f.16919 Date: Wed, 28 Aug 2019 08:42:34 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 1 on bug 11150= 6 from Andrew Sheldon
I should note that it doesn't flicker at all with the modifica=
tion I suggested.
Presumably, LFC is in fact kicking in at 30fps and below, so assuming that's
the case, it's not really LFC in general that is the problem, just LFC when
just below the minimum.=20

One possibility is that LFC is somehow generating frames at a rate above the
maximum refresh rate for framerates above 30 and below the minimum (35), si=
nce
the range is fairly narrow. Maybe it's tripling rather than doubling the
framerate?


You are receiving this mail because:
  • You are the assignee for the bug.
= --15669817541.aCDe27c4f.16919-- --===============1175010455== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1175010455==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 111506] [amdgpu] VRR/Freesync below the range (LFC) flickering (5700 XT) Date: Thu, 10 Oct 2019 05:43:54 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1084322844==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id BBE406EA8D for ; Thu, 10 Oct 2019 05:43:54 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1084322844== Content-Type: multipart/alternative; boundary="15706862341.4fD2C7f57.30761" Content-Transfer-Encoding: 7bit --15706862341.4fD2C7f57.30761 Date: Thu, 10 Oct 2019 05:43:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D111506 --- Comment #2 from Andrew Sheldon --- Looks to be fixed by commit 109b3e3e13507ad0908ff00bc7eb759ed41b88be drm/amd/display: Improve LFC behaviour It now smoothly transitions between LFC and VRR without flickering. --=20 You are receiving this mail because: You are the assignee for the bug.= --15706862341.4fD2C7f57.30761 Date: Thu, 10 Oct 2019 05:43:54 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 2 on bug 11150= 6 from Andrew Sheldon
Looks to be fixed by commit 109b3e3e13507ad0908ff00bc7eb759ed4=
1b88be

drm/amd/display: Improve LFC behaviour

It now smoothly transitions between LFC and VRR without flickering.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15706862341.4fD2C7f57.30761-- --===============1084322844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1084322844==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 111506] [amdgpu] VRR/Freesync below the range (LFC) flickering (5700 XT) Date: Tue, 19 Nov 2019 09:50:46 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1486535647==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id E00266F42B for ; Tue, 19 Nov 2019 09:50:45 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1486535647== Content-Type: multipart/alternative; boundary="15741570452.afb0B6.12851" Content-Transfer-Encoding: 7bit --15741570452.afb0B6.12851 Date: Tue, 19 Nov 2019 09:50:45 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D111506 Martin Peres changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #3 from Martin Peres --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this = link to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/897. --=20 You are receiving this mail because: You are the assignee for the bug.= --15741570452.afb0B6.12851 Date: Tue, 19 Nov 2019 09:50:45 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated <= span class=3D"fn">Martin Peres changed bug 11150= 6
What Removed Added
Resolution --- MOVED
Status NEW RESOLVED

Commen= t # 3 on bug 11150= 6 from Martin Peres
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this =
link
to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/897.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15741570452.afb0B6.12851-- --===============1486535647== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1486535647==--