[Bug 205393] [amdgpu powerplay] vega10: custom pp_table, AVFS accidentally reenabled after display powersave - bugzilla-daemon

From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 205393] [amdgpu powerplay] vega10: custom pp_table, AVFS accidentally reenabled after display powersave
Date: Thu, 07 Nov 2019 18:18:16 +0000	[thread overview]
Message-ID: <bug-205393-2300-uWiVGTbNW5@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-205393-2300@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=205393

--- Comment #4 from haro41@gmx.de ---
Yes, your patch works and has the same effect, apparently.

What confused me and the reason why i prefered to leave the
vega10_update_avfs() call before the flag modification, was the code inside
vega10_update_avfs():

static int vega10_update_avfs(struct pp_hwmgr *hwmgr)
{
        struct vega10_hwmgr *data = hwmgr->backend;

        if (data->need_update_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
                vega10_avfs_enable(hwmgr, false);
        } else if (data->need_update_dpm_table) {
                vega10_avfs_enable(hwmgr, false);
                vega10_avfs_enable(hwmgr, true);
        } else {
                vega10_avfs_enable(hwmgr, true);
        }

        return 0;
}

Here is a disable/enable sequence inserted, perhaps for a reason?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel