From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06CE7C433EF for ; Fri, 7 Jan 2022 02:16:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0610010F0C8; Fri, 7 Jan 2022 02:16:53 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id E120E10F0C7 for ; Fri, 7 Jan 2022 02:16:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 35EB861E87 for ; Fri, 7 Jan 2022 02:16:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id A17E6C36AE5 for ; Fri, 7 Jan 2022 02:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641521810; bh=eGq+XXJPHqkMVPRhTHy/aCxmZfC4+q5pNvgaTRzDJMw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=hK+QIqjClvBsKcMYLndCZ8w22wXBUkz9hr9JiEV0X5L1Rz4g5mhHk8LDvHni8n7xu plhBtCcmjMGRBxRgEqJ3YSMcUOvpTCYVFQ6vmdyFWK0Jv3ji1saAZD9j5LJ5z4Fyqu +XRFvaubxcBWFz+qodMrj2cRt/hlrTBK/3tJuDjL4WKArpLV2hjKuRRtP5yTqaCEHL /bQX0hO/dIvfUxx0+Vhff9ktn8pgyCf6yJ35mNbNS8hsyflHbHdTBYZluxbaH2QPvR 3On0bM7sVS2hyWqQMD/gKBNhlWwn+3IV0bLlQ8HUR/CfbL0FKyMWgR9wzUMHwWQYzx y0WbIPo9eirGw== Received: by aws-us-west-2-korg-bugzilla-1.web.codeaurora.org (Postfix, from userid 48) id 8773BC05FDF; Fri, 7 Jan 2022 02:16:50 +0000 (UTC) From: bugzilla-daemon@bugzilla.kernel.org To: dri-devel@lists.freedesktop.org Subject: [Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption Date: Fri, 07 Jan 2022 02:16:50 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Drivers X-Bugzilla-Component: Video(Other) X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: javier@dowhile0.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: drivers_video-other@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" https://bugzilla.kernel.org/show_bug.cgi?id=3D215001 --- Comment #5 from Javier Martinez Canillas (javier@dowhile0.org) --- Created attachment 300235 --> https://bugzilla.kernel.org/attachment.cgi?id=3D300235&action=3Dedit [PATCH] video: vga16fb: Only probe for EGA and VGA 16 color graphic cards Can you try the attached (untested) patch? The commit you mention in Comment 3 didn't change any logic but just moved = the platform device registration that match the vesafb and efifb drivers. As far as I can tell, the problem is that the vga16fb driver doesn't check = if the video modes are one that's supported by it and just blindly attempts to probe the driver. This probably wasn't a problem before because the sysfb.o was in arch/x86/kernel but no is in drivers/firmware. But the issue in vga16fb was present before, just moving exposed it. I believe that the correct thing is to check if screen_info says that's a {E,V}GA 16 color mode and fail to probe the vga16fb driver otherwise. --=20 You may reply to this email to add a comment. You are receiving this mail because: You are on the CC list for the bug.=