From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 2377] Polygon stipple broken. Date: Thu, 17 Jan 2013 17:44:09 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1899043695==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D0E6E6C87 for ; Thu, 17 Jan 2013 09:44:09 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1899043695== Content-Type: multipart/alternative; boundary="1358444649.64eEAf21.2219"; charset="us-ascii" --1358444649.64eEAf21.2219 Date: Thu, 17 Jan 2013 17:44:09 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=2377 --- Comment #7 from Roland Scheidegger --- Looks to me like the offsets for the stipple pattern are wrong. These are set in r200UpdateViewportOffset - which has no callers. I noted this in bug 57842, and tried to address it there though the patch probably wasn't really right in any case, but you could try that as a starting point. (I'm not sure though if actually we don't also need to take viewport into account for the offsets? Maybe not though. I'm pretty sure though stippling also additionally would be broken for fbo's (but certainly should go unnoticed by this test), as the code does as the comment says, always invert the stippling pattern, and the y offset is also always calculated taking the window height into account, and I strongly suspect both aren't right for fbos.) -- You are receiving this mail because: You are the assignee for the bug. --1358444649.64eEAf21.2219 Date: Thu, 17 Jan 2013 17:44:09 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 7 on bug 2377 from 
Looks to me like the offsets for the stipple pattern are wrong.
These are set in r200UpdateViewportOffset - which has no callers. I noted this
in bug 57842, and tried to address it there though the patch probably wasn't
really right in any case, but you could try that as a starting point.
(I'm not sure though if actually we don't also need to take viewport into
account for the offsets? Maybe not though. I'm pretty sure though stippling
also additionally would be broken for fbo's (but certainly should go unnoticed
by this test), as the code does as the comment says, always invert the
stippling pattern, and the y offset is also always calculated taking the window
height into account, and I strongly suspect both aren't right for fbos.)

You are receiving this mail because:
  • You are the assignee for the bug.
--1358444649.64eEAf21.2219-- --===============1899043695== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1899043695==--