[Bug 47765] New: Corrupt rendering to a window between 57 and 63 pixels high

[Bug 47765] New: Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

             Bug #: 47765
           Summary: Corrupt rendering to a window between 57 and 63 pixels
                    high
    Classification: Unclassified
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r600
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: tvrtko.ursulin@onelan.co.uk


We are seeing render corruption when rendering a texture to a window between 57
and 63 pixels high. glViewport being set to window dimensions.

Texture vertices do not seem to matter. If I render to the full viewport, or to
a subset of a viewport, always the whole viewport gets corrupt (so including
the area outside texture vertices).

Texture size does not seem to matter.

Rendering is done with glDrawArray GL_TRIANGLE_FAN and the destination window
is RGBA.

Environment:

00:01.0 VGA compatible controller: ATI Technologies Inc AMD Radeon HD 6310
GraphicsATI

Kernel 3.3.0 + 0001-drm-radeon-add-support-for-evergreen-ni-tiling-infor.patch

It does not happen without this patch - so it is probably tiling related.

xorg-drivers-ati, mesa and libdrm from yesterday's git. Last one is in fact a
bit older, but I applied a single interesting patch
(9b3ad51ae5fd9654df8ef75de845a519015150bb) by hand to make it up to date.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #1 from Jerome Glisse <glisse@freedesktop.org> 2012-03-23 07:49:55 PDT ---
Does any of the mesa demo reproduce the bug ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #2 from Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk> 2012-03-23 08:22:20 PDT ---
(In reply to comment #1)
> Does any of the mesa demo reproduce the bug ?

/usr/lib64/mesa/tri shows it if you resize the window right.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #3 from Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk> 2012-03-23 08:28:01 PDT ---
Created attachment 58939
  --> https://bugs.freedesktop.org/attachment.cgi?id=58939
Screenshot showing corrupted mesa-demos/tri rendering

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #4 from Jerome Glisse <glisse@freedesktop.org> 2012-03-27 09:30:15 PDT ---
Please attach patch corresponding to 9b3ad51ae5fd9654df8ef75de845a519015150bb

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #5 from Jerome Glisse <glisse@freedesktop.org> 2012-03-27 11:49:06 PDT ---
Created attachment 59126
  --> https://bugs.freedesktop.org/attachment.cgi?id=59126
use linear aligned

Does this patch against ddx help ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #6 from Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk> 2012-03-28 01:17:21 UTC ---
(In reply to comment #5)
> Created attachment 59126 [details] [review]
> use linear aligned
> 
> Does this patch against ddx help ?

No, still the same corruption.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #7 from Alex Deucher <agd5f@yahoo.com> 2012-04-04 06:40:43 PDT ---
Does this patch help?
http://people.freedesktop.org/~agd5f/0001-drm-radeon-kms-Fixup-backendmap-on-6xx-9xx.patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #8 from Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk> 2012-04-04 06:57:36 PDT ---
(In reply to comment #7)
> Does this patch help?
> http://people.freedesktop.org/~agd5f/0001-drm-radeon-kms-Fixup-backendmap-on-6xx-9xx.patch

Unfortunately not, still the same behaviour.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

Jerome Glisse <glisse@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59494|0                           |1
        is obsolete|                            |

--- Comment #11 from Jerome Glisse <glisse@freedesktop.org> 2012-04-04 15:43:39 UTC ---
Created attachment 59495
  --> https://bugs.freedesktop.org/attachment.cgi?id=59495
Fix pixmap.height < 64 case

Sorry attached wrong patch, ignore previous patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #9 from Jerome Glisse <glisse@freedesktop.org> 2012-04-04 14:13:45 PDT ---
Created attachment 59494
  --> https://bugs.freedesktop.org/attachment.cgi?id=59494
Fix pixmap.height < 64 case

This should fix your issue (patch against ddx xf86-video-ati)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #10 from Andy Furniss <lists@andyfurniss.entadsl.com> 2012-04-04 15:14:53 PDT ---
(In reply to comment #9)
> Created attachment 59494 [details] [review]
> Fix pixmap.height < 64 case
> 
> This should fix your issue (patch against ddx xf86-video-ati)

Doesn't help on my rv790 - I am testing just this patch not the kernel one.

FWIW I only see this when swapbufferswait is off, looks like most/any mesa demo
will show it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #12 from Andy Furniss <lists@andyfurniss.entadsl.com> 2012-04-04 16:08:37 PDT ---
(In reply to comment #11)
> Created attachment 59495 [details] [review]
> Fix pixmap.height < 64 case
> 
> Sorry attached wrong patch, ignore previous patch

This one works for me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

--- Comment #13 from Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk> 2012-04-05 01:03:46 PDT ---
(In reply to comment #11)
> Created attachment 59495 [details] [review]
> Fix pixmap.height < 64 case
> 
> Sorry attached wrong patch, ignore previous patch

Works lovely, thank you!

Interestingly we were on a similar track here trying to force something similar
but in libdrm. But I am not surprised since I cannot say I picked up what
component does what (kernel, libdrm, mesa, ddx) in the few weeks I've been in
this code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 47765] Corrupt rendering to a window between 57 and 63 pixels high

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47765

Jerome Glisse <glisse@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Jerome Glisse <glisse@freedesktop.org> 2012-04-05 13:37:55 PDT ---
Closing pushed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.