dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 49140] r600_state_common.c:761:r600_draw_vbo: Assertion `0' failed
Date: Thu, 03 May 2012 05:42:10 +0000	[thread overview]
Message-ID: <bug-49140-502-ox1dWfW5qw@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-49140-502@http.bugs.freedesktop.org/>

https://bugs.freedesktop.org/show_bug.cgi?id=49140

--- Comment #5 from Marko <bgz.marko@gmail.com> 2012-05-02 22:42:10 PDT ---

>     vec3 p3 = vec3(p.x, p.y, p.z);
>     float t = dot(v, p3);
>     float t2 = gm1*t/v2 - g*p.w;
>     r = vec4( v*t2 + p3, g * (p.w - t));
> 

Vadim, this is really great and much appreciated. I went through the steps and
it all seems fine to me, also tested some examples and everything works great.
This also makes the advanced path in the shader work again without my quirky
workarounds in the while loop. I never really took much care with these kind of
optimisations, somehow blindly hoping that the compiler will automagically
optimise everything. I'll try to be more careful in advance. 

I'd like to put some comments in the code, like "optimised by Vadim" if that's
ok with you or perhaps should I use your real name? Thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

  parent reply	other threads:[~2012-05-03  5:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 12:21 [Bug 49140] New: r600_state_common.c:761:r600_draw_vbo: Assertion `0' failed bugzilla-daemon
2012-04-25 23:06 ` [Bug 49140] " bugzilla-daemon
2012-04-26  7:27 ` bugzilla-daemon
2012-04-26 10:43 ` bugzilla-daemon
2012-04-27  0:38 ` bugzilla-daemon
2012-05-03  5:42 ` bugzilla-daemon [this message]
2012-05-03 10:16 ` bugzilla-daemon
2012-10-20 13:23 ` bugzilla-daemon
2019-09-18 18:59 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49140-502-ox1dWfW5qw@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox