[Bug 54867] bug in r300 compiler

[bugzilla-daemon@freedesktop.org]

[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=54867

--- Comment #2 from Tom Stellard <tstellar@gmail.com> ---
Comment on attachment 80074
  --> https://bugs.freedesktop.org/attachment.cgi?id=80074
s/signed/int/

Review of attachment 80074:
-----------------------------------------------------------------

This patch looks good to me, but for the commit message, you need to wrap long
lines to 80 or fewer characters (I actually wrap to 75, but I'm not sure what
the standard convention is) and re-organize the commit message in the form of:

Code area: Brief description

Long description (if necessary)

Link to fixed bugs

For this patch, it should be something like:


r300g/compiler: Fix unsigned comparison with less than zero

rc_find_free_temporary_list() returns signed integer (in case of lack of free
temporary registersreturns -1), so new_index in radeon_rename_regs() should be
signed.

https://bugs.freedesktop.org/show_bug.cgi?id=54867

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2354 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel