From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 54867] bug in r300 compiler Date: Mon, 03 Jun 2013 13:31:28 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1138862100==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id B1D0DE5EA1 for ; Mon, 3 Jun 2013 06:31:28 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1138862100== Content-Type: multipart/alternative; boundary="1370266288.d8Edf0.30221"; charset="us-ascii" --1370266288.d8Edf0.30221 Date: Mon, 3 Jun 2013 13:31:28 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=54867 --- Comment #2 from Tom Stellard --- Comment on attachment 80074 --> https://bugs.freedesktop.org/attachment.cgi?id=80074 s/signed/int/ Review of attachment 80074: ----------------------------------------------------------------- This patch looks good to me, but for the commit message, you need to wrap long lines to 80 or fewer characters (I actually wrap to 75, but I'm not sure what the standard convention is) and re-organize the commit message in the form of: Code area: Brief description Long description (if necessary) Link to fixed bugs For this patch, it should be something like: r300g/compiler: Fix unsigned comparison with less than zero rc_find_free_temporary_list() returns signed integer (in case of lack of free temporary registersreturns -1), so new_index in radeon_rename_regs() should be signed. https://bugs.freedesktop.org/show_bug.cgi?id=54867 -- You are receiving this mail because: You are the assignee for the bug. --1370266288.d8Edf0.30221 Date: Mon, 3 Jun 2013 13:31:28 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 2 on bug 54867 from 
Comment on attachment 80074 [details] [review]
s/signed/int/

Review of attachment 80074 [details] [review]:
-----------------------------------------------------------------

This patch looks good to me, but for the commit message, you need to wrap long
lines to 80 or fewer characters (I actually wrap to 75, but I'm not sure what
the standard convention is) and re-organize the commit message in the form of:

Code area: Brief description

Long description (if necessary)

Link to fixed bugs

For this patch, it should be something like:


r300g/compiler: Fix unsigned comparison with less than zero

rc_find_free_temporary_list() returns signed integer (in case of lack of free
temporary registersreturns -1), so new_index in radeon_rename_regs() should be
signed.

https://bugs.freedesktop.org/show_bug.cgi?id=54867

You are receiving this mail because:
  • You are the assignee for the bug.
--1370266288.d8Edf0.30221-- --===============1138862100== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1138862100==--