From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (CAYMAN) Date: Sat, 27 Oct 2012 04:51:49 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0838250419==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 565349E89D for ; Fri, 26 Oct 2012 21:51:49 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0838250419== Content-Type: multipart/alternative; boundary="1351313509.45AB2E0.27429"; charset="us-ascii" --1351313509.45AB2E0.27429 Date: Sat, 27 Oct 2012 04:51:49 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=56139 --- Comment #6 from Alexandre Demers --- (In reply to comment #5) > Created attachment 69113 [details] [review] > possible fix > > (In reply to comment #4) > > the bug appeared. So it seems blanking the display controllers with for(i = > > 0; i < rdev->num_crtc; i++) is not equivalent to the code that it replaces. > > The original code first wrote in the EVERGREEN_CRTC_UPDATE_LOCK registers, > > before setting EVERGREEN_CRTC_CONTROL registers and writing again in the > > EVERGREEN_CRTC_UPDATE_LOCK registers. On the other hand, the new code > > doesn't write in the EVERGREEN_CRTC_UPDATE_LOCK neither before nor after > > setting EVERGREEN_CRTC_CONTROL. > > It should be equivalent. CRTC_UPDATE_LOCK turns off double buffering in the > crtc which makes register updates atomic. The new code waits for the frame > count to increase (the double buffered updates happen at vblank) so it > should be equivalent. That said, it shouldn't hurt to take the lock. Does > this patch help? Sadly, it didn't help. -- You are receiving this mail because: You are the assignee for the bug. --1351313509.45AB2E0.27429 Date: Sat, 27 Oct 2012 04:51:49 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 6 on bug 56139 from 
(In reply to comment #5)
> Created attachment 69113 [details] [review] [review]
> possible fix
> 
> (In reply to comment #4)
> > the bug appeared. So it seems blanking the display controllers with for(i =
> > 0; i < rdev->num_crtc; i++) is not equivalent to the code that it replaces.
> > The original code first wrote in the EVERGREEN_CRTC_UPDATE_LOCK registers,
> > before setting EVERGREEN_CRTC_CONTROL registers and writing again in the
> > EVERGREEN_CRTC_UPDATE_LOCK registers. On the other hand, the new code
> > doesn't write in the EVERGREEN_CRTC_UPDATE_LOCK neither before nor after
> > setting EVERGREEN_CRTC_CONTROL.
> 
> It should be equivalent.  CRTC_UPDATE_LOCK turns off double buffering in the
> crtc which makes register updates atomic.  The new code waits for the frame
> count to increase (the double buffered updates happen at vblank) so it
> should be equivalent.  That said, it shouldn't hurt to take the lock.  Does
> this patch help?

Sadly, it didn't help.

You are receiving this mail because:
  • You are the assignee for the bug.
--1351313509.45AB2E0.27429-- --===============0838250419== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0838250419==--