From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 57842] r200: Culling is broken when rendering to an FBO
Date: Sun, 30 Dec 2012 22:32:45 +0000 [thread overview]
Message-ID: <bug-57842-502-2fsvWkO2aL@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-57842-502@http.bugs.freedesktop.org/>
[-- Attachment #1.1: Type: text/plain, Size: 1305 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=57842
--- Comment #13 from Roland Scheidegger <sroland@vmware.com> ---
(In reply to comment #11)
> Created attachment 72051 [details] [review]
> attachment 72047 [details] as patch for r200/radeon
>
> @comment 9: your own attachment says it was not.
> Anyway, attachment 72047 [details] translated into a patch.
>
> 'cull_face = (mode == GL_CW) ? R200_FFACE_CULL_CW : R200_FFACE_CULL_CCW'
> is bit of a mouthful, but atm. I've got not idea how to turn that into
> proper obfuscation style of mesa sources.
patch looks correct to me. TCL culling is part of the tcl engine and hence
ignored if there's no TCL. But viewport transform (which is where the fbo
inversion happens) is done later, hence TCL culling is not subject to that
inversion.
FWIW it would also be possible to simply disable TCL culling, setup culling is
enough. The docs are actually saying it TCL culling is a performance
optimization with questionable quality (as the coords aren't snapped to
rasterizer subpixels). I guess it would also be possible to disable setup
culling instead (of course only with tcl) but I'm not sure if that would make
any performance compared to having enabled culling at both places.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2902 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-12-30 22:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 15:12 [Bug 57842] New: r200: Culling is broken when rendering to an FBO bugzilla-daemon
2012-12-04 20:20 ` [Bug 57842] " bugzilla-daemon
2012-12-04 20:57 ` bugzilla-daemon
2012-12-05 8:50 ` bugzilla-daemon
2012-12-05 8:51 ` bugzilla-daemon
2012-12-23 23:41 ` bugzilla-daemon
2012-12-24 0:19 ` bugzilla-daemon
2012-12-24 1:04 ` bugzilla-daemon
2012-12-24 1:16 ` bugzilla-daemon
2012-12-24 1:36 ` bugzilla-daemon
2012-12-24 2:18 ` bugzilla-daemon
2012-12-24 2:22 ` bugzilla-daemon
2012-12-24 3:02 ` bugzilla-daemon
2012-12-24 3:38 ` bugzilla-daemon
2012-12-30 22:32 ` bugzilla-daemon [this message]
2013-01-02 22:42 ` bugzilla-daemon
2013-01-03 5:14 ` bugzilla-daemon
2013-01-03 14:17 ` bugzilla-daemon
2013-01-03 18:31 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-57842-502-2fsvWkO2aL@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).