From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 57842] r200: Culling is broken when rendering to an FBO Date: Tue, 04 Dec 2012 20:20:18 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0495514893==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AC0FE6021 for ; Tue, 4 Dec 2012 12:20:18 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0495514893== Content-Type: multipart/alternative; boundary="1354652418.fdEF6821.29979"; charset="us-ascii" --1354652418.fdEF6821.29979 Date: Tue, 4 Dec 2012 20:20:18 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=57842 --- Comment #1 from Roland Scheidegger --- Hmm this is odd I can't see anything wrong with the culling setup wrt fbos. The viewport, window handling though seems somewhat bogus. First, r200UpdateViewportOffset() has no callers (it is used in radeon->vtbl.update_viewport_offset but that one seems to have no callers neither). This function would not take the y flip into account but since it isn't used... I'd just get rid of it but it's the only thing handling stippling that probably needs to move somewhere else. Also, both r200UpdateViewportOffset() and r200UpdateWindow() use the driDrawable height for the yoffset in the viewport. I don't think that will work for fbos, should just use the ctx->DrawBuffer height instead? I can't see though why that would just cause failures with culling. -- You are receiving this mail because: You are the assignee for the bug. --1354652418.fdEF6821.29979 Date: Tue, 4 Dec 2012 20:20:18 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 1 on bug 57842 from 
Hmm this is odd I can't see anything wrong with the culling setup wrt fbos.
The viewport, window handling though seems somewhat bogus.
First, r200UpdateViewportOffset() has no callers (it is used in
radeon->vtbl.update_viewport_offset but that one seems to have no callers
neither). This function would not take the y flip into account but since it
isn't used... I'd just get rid of it but it's the only thing handling stippling
that probably needs to move somewhere else.
Also, both r200UpdateViewportOffset() and r200UpdateWindow() use the
driDrawable height for the yoffset in the viewport. I don't think that will
work for fbos, should just use the ctx->DrawBuffer height instead?
I can't see though why that would just cause failures with culling.

You are receiving this mail because:
  • You are the assignee for the bug.
--1354652418.fdEF6821.29979-- --===============0495514893== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0495514893==--