From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 57984] New: r300g: blend sfactor=GL_DST_COLOR fails with FBOs Date: Fri, 07 Dec 2012 15:41:12 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0569557941==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id B0F2DE5C97 for ; Fri, 7 Dec 2012 07:41:12 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0569557941== Content-Type: multipart/alternative; boundary="1354894872.f60B0.10942"; charset="us-ascii" --1354894872.f60B0.10942 Date: Fri, 7 Dec 2012 15:41:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=57984 Priority: medium Bug ID: 57984 Assignee: dri-devel@lists.freedesktop.org Summary: r300g: blend sfactor=GL_DST_COLOR fails with FBOs Severity: normal Classification: Unclassified OS: All Reporter: stefandoesinger@gmx.at Hardware: All Status: NEW Version: git Component: Drivers/Gallium/r300 Product: Mesa Created attachment 71134 --> https://bugs.freedesktop.org/attachment.cgi?id=71134&action=edit Screenshot showing the problem. When running 3DMark2001 on Wine with r300g rendering corruptions are visible in the load screen and the high quality version of the "lobby" test. Closer investigation showed that the problem occurs when the game sets the source blend factor to GL_DST_COLOR and the dest blend factor to GL_ZERO. The blend function is ADD, separate alpha blending is not used. If I manually change these parameters to srcfactor=ZERO and dstfactor=GL_SRC_COLOR, rendering works correctly. Rendering also works fine when I configure wine not to use FBOs. I have tried to reproduce this problem with a stand-alone GL application but have not succeeded in that yet. I have attached a screenshot. The corruption are the random pixels at the bottom and right. The horizontal lines are artifacts caused by the gnome-screenshot tool. 3DMark2001 can be downloaded from http://download.freenet.de/3DMark-2001-SE-Windows--4183.xhtml and many other places. -- You are receiving this mail because: You are the assignee for the bug. --1354894872.f60B0.10942 Date: Fri, 7 Dec 2012 15:41:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"
Priority medium
Bug ID 57984
Assignee dri-devel@lists.freedesktop.org
Summary r300g: blend sfactor=GL_DST_COLOR fails with FBOs
Severity normal
Classification Unclassified
OS All
Reporter stefandoesinger@gmx.at
Hardware All
Status NEW
Version git
Component Drivers/Gallium/r300
Product Mesa 

Created attachment 71134 [details]
Screenshot showing the problem.

When running 3DMark2001 on Wine with r300g rendering corruptions are visible in
the load screen and the high quality version of the "lobby" test. Closer
investigation showed that the problem occurs when the game sets the source
blend factor to GL_DST_COLOR and the dest blend factor to GL_ZERO. The blend
function is ADD, separate alpha blending is not used.

If I manually change these parameters to srcfactor=ZERO and
dstfactor=GL_SRC_COLOR, rendering works correctly.

Rendering also works fine when I configure wine not to use FBOs.

I have tried to reproduce this problem with a stand-alone GL application but
have not succeeded in that yet.

I have attached a screenshot. The corruption are the random pixels at the
bottom and right. The horizontal lines are artifacts caused by the
gnome-screenshot tool.

3DMark2001 can be downloaded from
http://download.freenet.de/3DMark-2001-SE-Windows--4183.xhtml and many other
places.

You are receiving this mail because:
  • You are the assignee for the bug.
--1354894872.f60B0.10942-- --===============0569557941== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0569557941==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 57984] r300g: blend sfactor=GL_DST_COLOR fails with FBOs Date: Fri, 07 Dec 2012 15:57:55 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0601387677==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id E615DE5CCE for ; Fri, 7 Dec 2012 07:57:55 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0601387677== Content-Type: multipart/alternative; boundary="1354895875.14BC28E0.13436"; charset="us-ascii" --1354895875.14BC28E0.13436 Date: Fri, 7 Dec 2012 15:57:55 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D57984 --- Comment #1 from Stefan D=C3=B6singer --- I dug through the optimizations in r300_create_blend_state, and the problem= is the "Disable reading if SRC_ALPHA =3D=3D 0" optimization. It is not correct= if the source factor is DEST_COLOR. I'm checking if any other source factors have = to be excluded. --=20 You are receiving this mail because: You are the assignee for the bug. --1354895875.14BC28E0.13436 Date: Fri, 7 Dec 2012 15:57:55 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Comment= # 1 on bug 57984<= /a> from Stefan D=C3=B6singer 
I dug through the optimizations in r300_create_blend_state, an=
d the problem is
the "Disable reading if SRC_ALPHA =3D=3D 0" optimization. It is n=
ot correct if the
source factor is DEST_COLOR. I'm checking if any other source factors have =
to
be excluded.

You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1354895875.14BC28E0.13436-- --===============0601387677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0601387677==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 57984] r300g: blend sfactor=GL_DST_COLOR fails with FBOs Date: Fri, 07 Dec 2012 16:41:45 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0564778230==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 75815E6784 for ; Fri, 7 Dec 2012 08:41:45 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0564778230== Content-Type: multipart/alternative; boundary="1354898505.82D2131.19828"; charset="us-ascii" --1354898505.82D2131.19828 Date: Fri, 7 Dec 2012 16:41:45 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D57984 --- Comment #2 from Marek Ol=C5=A1=C3=A1k --- (In reply to comment #1) > I dug through the optimizations in r300_create_blend_state, and the probl= em > is the "Disable reading if SRC_ALPHA =3D=3D 0" optimization. It is not co= rrect > if the source factor is DEST_COLOR. I'm checking if any other source fact= ors > have to be excluded. Yes, you're right. The optimization should check the source RGB and A facto= rs too. --=20 You are receiving this mail because: You are the assignee for the bug. --1354898505.82D2131.19828 Date: Fri, 7 Dec 2012 16:41:45 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Comment= # 2 on bug 57984<= /a> from Marek Ol=C5=A1=C3=A1k 
(In reply to comment #1=
)
> I dug through the optimizations in r300_create_b=
lend_state, and the problem
> is the "Disable reading if SRC_ALPHA =3D=3D 0" optimization.=
 It is not correct
> if the source factor is DEST_COLOR. I'm checking if any other source f=
actors
> have to be excluded.

Yes, you're right. The optimization should check the source RGB and A facto=
rs
too.

You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1354898505.82D2131.19828-- --===============0564778230== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0564778230==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 57984] r300g: blend sfactor=GL_DST_COLOR fails with FBOs Date: Fri, 07 Dec 2012 17:32:46 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2135713022==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B83EE5D58 for ; Fri, 7 Dec 2012 09:32:46 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2135713022== Content-Type: multipart/alternative; boundary="1354901566.81FF21.26244"; charset="us-ascii" --1354901566.81FF21.26244 Date: Fri, 7 Dec 2012 17:32:46 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=57984 Andreas Boll changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71134|text/plain |image/png mime type| | -- You are receiving this mail because: You are the assignee for the bug. --1354901566.81FF21.26244 Date: Fri, 7 Dec 2012 17:32:46 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 57984
What Removed Added
Attachment #71134 mime type text/plain image/png

You are receiving this mail because:
  • You are the assignee for the bug.
--1354901566.81FF21.26244-- --===============2135713022== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2135713022==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 57984] r300g: blend sfactor=GL_DST_COLOR fails with FBOs Date: Fri, 07 Dec 2012 17:35:56 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1235427095==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 898EAE5D58 for ; Fri, 7 Dec 2012 09:35:56 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1235427095== Content-Type: multipart/alternative; boundary="1354901756.Ce6b1.26765"; charset="us-ascii" --1354901756.Ce6b1.26765 Date: Fri, 7 Dec 2012 17:35:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=57984 Alex Deucher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. --1354901756.Ce6b1.26765 Date: Fri, 7 Dec 2012 17:35:56 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 57984
What Removed Added
Status NEW RESOLVED
Resolution --- FIXED

You are receiving this mail because:
  • You are the assignee for the bug.
--1354901756.Ce6b1.26765-- --===============1235427095== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1235427095==--