From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 63579] Savage 2 Edges render white [r600g] Date: Tue, 16 Apr 2013 03:43:25 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0713728724==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E725E5C14 for ; Mon, 15 Apr 2013 20:43:25 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0713728724== Content-Type: multipart/alternative; boundary="1366083805.22ADd0Fd0.24864"; charset="us-ascii" --1366083805.22ADd0Fd0.24864 Date: Tue, 16 Apr 2013 03:43:25 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #5 from Matt Turner --- (In reply to comment #4) > Looks like some shaders related to sky rendering are not compiled > successfully. The problem is that there is a '\' (line-continuation) > character in the comment, followed by the line that is not expected to be a > part of comment: > > #version 120 > .... > // > ============================================================================= > \ > uniform vec4 vColor; > > AFAICS the line-continuation character was only introduced in the GLSL 4.20 > spec, and according to the spec next line should be considered a part of the > comment in this case. I'm not sure though how this should be handled for > previous GLSL versions. > > So either this is incorrectly handled by the GLSL compiler, or the shader > itself is incorrect. In any case it's not a bug of the r600g driver. > > I think the easiest solution would be for game devs to remove the '\' > character from that comment to avoid this uncertainty and undefined > behavior, probably it was added accidentally anyway. You might want to > report this to the game developers. The shader is incorrect. There is a drirc workaround for this already. I suppose it's just not wired up for Gallium. -- You are receiving this mail because: You are the assignee for the bug. --1366083805.22ADd0Fd0.24864 Date: Tue, 16 Apr 2013 03:43:25 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 5 on bug 63579 from
(In reply to comment #4)
> Looks like some shaders related to sky rendering are not compiled
> successfully. The problem is that there is a '\' (line-continuation)
> character in the comment, followed by the line that is not expected to be a
> part of comment:
> 
> #version 120
> ....
> //
> =============================================================================
> \
> uniform vec4    vColor;
> 
> AFAICS the line-continuation character was only introduced in the GLSL 4.20
> spec, and according to the spec next line should be considered a part of the
> comment in this case. I'm not sure though how this should be handled for
> previous GLSL versions.
> 
> So either this is incorrectly handled by the GLSL compiler, or the shader
> itself is incorrect. In any case it's not a bug of the r600g driver.
> 
> I think the easiest solution would be for game devs to remove the '\'
> character from that comment to avoid this uncertainty and undefined
> behavior, probably it was added accidentally anyway. You might want to
> report this to the game developers.

The shader is incorrect. There is a drirc workaround for this already. I
suppose it's just not wired up for Gallium.


You are receiving this mail because:
  • You are the assignee for the bug.
--1366083805.22ADd0Fd0.24864-- --===============0713728724== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0713728724==--