dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 63579] Savage 2 Edges render white [r600g]
Date: Tue, 16 Apr 2013 03:37:29 +0000	[thread overview]
Message-ID: <bug-63579-502-QCChMuANp0@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-63579-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1176 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=63579

--- Comment #4 from Vadim Girlin <ptpzz@yandex.ru> ---
Looks like some shaders related to sky rendering are not compiled successfully.
The problem is that there is a '\' (line-continuation) character in the
comment, followed by the line that is not expected to be a part of comment:

#version 120
....
//=============================================================================\
uniform vec4    vColor;

AFAICS the line-continuation character was only introduced in the GLSL 4.20
spec, and according to the spec next line should be considered a part of the
comment in this case. I'm not sure though how this should be handled for
previous GLSL versions.

So either this is incorrectly handled by the GLSL compiler, or the shader
itself is incorrect. In any case it's not a bug of the r600g driver.

I think the easiest solution would be for game devs to remove the '\' character
from that comment to avoid this uncertainty and undefined behavior, probably it
was added accidentally anyway. You might want to report this to the game
developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1917 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2013-04-16  3:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16  0:56 [Bug 63579] New: Savage 2 Edges render white [r600g] bugzilla-daemon
2013-04-16  0:57 ` [Bug 63579] " bugzilla-daemon
2013-04-16  0:58 ` bugzilla-daemon
2013-04-16  0:59 ` bugzilla-daemon
2013-04-16  2:11 ` bugzilla-daemon
2013-04-16  3:04 ` bugzilla-daemon
2013-04-16  3:37 ` bugzilla-daemon [this message]
2013-04-16  3:43 ` bugzilla-daemon
2013-04-16  4:37 ` bugzilla-daemon
2013-04-16  7:20 ` bugzilla-daemon
2013-04-16 17:25 ` bugzilla-daemon
2013-04-16 19:06 ` bugzilla-daemon
2013-04-17  8:32 ` bugzilla-daemon
2013-04-17 17:03 ` bugzilla-daemon
2013-04-17 17:10 ` bugzilla-daemon
2013-04-17 18:13 ` bugzilla-daemon
2013-04-17 18:51 ` bugzilla-daemon
2013-04-17 20:03 ` bugzilla-daemon
2013-04-17 20:52 ` bugzilla-daemon
2013-04-17 21:19 ` bugzilla-daemon
2013-04-17 21:38 ` bugzilla-daemon
2013-05-18  2:41 ` bugzilla-daemon
2013-05-18 12:37 ` bugzilla-daemon
2019-09-18 19:02 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63579-502-QCChMuANp0@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox