From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 66067] Trine 2's fragment normal buffer is mixtextured on Radeon HD 6770 (Juniper) Date: Sat, 13 Feb 2016 18:01:56 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1489915124==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B0016E39F for ; Sat, 13 Feb 2016 10:01:56 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1489915124== Content-Type: multipart/alternative; boundary="14553865160.57ce.15346"; charset="UTF-8" --14553865160.57ce.15346 Date: Sat, 13 Feb 2016 18:01:55 +0000 MIME-Version: 1.0 Content-Type: text/plain https://bugs.freedesktop.org/show_bug.cgi?id=66067 --- Comment #38 from Roland Scheidegger --- (In reply to Nicholas Miell from comment #37) > You could look for "# cgc version" near the beginning of the program source > (almost certainly the second line), but that assumes the shaders weren't > post-processed to strip out all the comments. > > Alternately, you could just disable it entirely by default and include a > driconf option. Actually I suppose in theory it would be possible to do this in the state tracker with relatively little overhead. You'd just have to validate the shadow targets the first time you draw for arb_fp shaders iff they have shadow sampler dcls and change them to non-shadow if the samplers don't have compare mode set (it would have to be conditional on a driconf variable though that way, because if you only validate the first time it would break conformant apps which happen to have the samplers wrong the first time they draw which could for instance happen if they try to force early compilation). Afterwards no further validation should be required. Not sure it's all that feasible though, for instance shader validation happens before texture/sampler validation so you'd need to be careful, probably would make the code somewhat ugly just for fixing broken shaders... -- You are receiving this mail because: You are the assignee for the bug. --14553865160.57ce.15346 Date: Sat, 13 Feb 2016 18:01:56 +0000 MIME-Version: 1.0 Content-Type: text/html

Comment # 38 on bug 66067 from
(In reply to Nicholas Miell from comment #37)
> You could look for "# cgc version" near the beginning of the program source
> (almost certainly the second line), but that assumes the shaders weren't
> post-processed to strip out all the comments.
> 
> Alternately, you could just disable it entirely by default and include a
> driconf option.

Actually I suppose in theory it would be possible to do this in the state
tracker with relatively little overhead. You'd just have to validate the shadow
targets the first time you draw for arb_fp shaders iff they have shadow sampler
dcls and change them to non-shadow if the samplers don't have compare mode set
(it would have to be conditional on a driconf variable though that way, because
if you only validate the first time it would break conformant apps which happen
to have the samplers wrong the first time they draw which could for instance
happen if they try to force early compilation). Afterwards no further
validation should be required.
Not sure it's all that feasible though, for instance shader validation happens
before texture/sampler validation so you'd need to be careful, probably would
make the code somewhat ugly just for fixing broken shaders...


You are receiving this mail because:
  • You are the assignee for the bug.
--14553865160.57ce.15346-- --===============1489915124== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1489915124==--