Comment=
# 5
on bug 67530<=
/a>
from Christian K=C3=B6nig
(In reply to comment #4=
)
> Created attachment 83741 [details]=
[review] [review]
> use more common defaults for the level
>=20
> This patch adds more common defaults as level. Imho they are likely not
> correct for all the hardware.
Not bad for a first try, but I have some minor comments:
> return true;
> case PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE:
> return true;
>+ case PIPE_VIDEO_CAP_MAX_LEVEL:
>+ switch (profile) {
>+ case PIPE_VIDEO_PROFILE_MPEG1:
The new code has a different indention, the radeon code uses tabs instead of
spaces, please fix.
Additional to that you need to fix all drivers to handle the new CAP, just
"grep -R PIPE_VIDEO_CAP_SUPPORTED src/gallium/drivers" to find al=
l those
places.
With that fixed please send the patch to the mesa maillinglist for review.<=
/pre>