Commen=
t # 25
on bug 68235<=
/a>
from Alexandre Demers
(In reply to comment #=
22)
> (In reply to comment #20)
> > Ok, if I apply the whole suggested patch but the following, it ha=
ngs:
> > @@ -4152,14 +4152,14 @@ int ni_dpm_init(struct ra=
deon_device *rdev)
> > }
> > ni_pi->mclk_rtt_mode_threshold =3D eg_pi->mclk_edc_wr_ena=
ble_threshold;
> >=20=20
> > - pi->voltage_control =3D
> > - radeon_atom_is_voltage_gpio(rdev, SET_VOLTAGE_TYPE_ASIC_VDDC, =
0);
> > + pi->voltage_control =3D false;
> > +// radeon_atom_is_voltage_gpio(rdev, SET_VOLTAGE_TYPE_ASIC_VDDC=
, 0);
> >=20=20
> > - pi->mvdd_control =3D
> > - radeon_atom_is_voltage_gpio(rdev, SET_VOLTAGE_TYPE_ASIC_MVDDC,=
0);
> > + pi->mvdd_control =3D false;
> > +// radeon_atom_is_voltage_gpio(rdev, SET_VOLTAGE_TYPE_ASIC_MVDD=
C, 0);
> >=20=20
> > - eg_pi->vddci_control =3D
> > - radeon_atom_is_voltage_gpio(rdev, SET_VOLTAGE_TYPE_ASIC_VDDCI,=
0);
> > + eg_pi->vddci_control =3D false;
> > +// radeon_atom_is_voltage_gpio(rdev, SET_VOLTAGE_TYPE_ASIC_VDDC=
I, 0);
> >=20=20
> > rv770_get_engine_memory_ss(rdev);
>=20
> So does just applying this portion of the patch by itself fix the hang=
?
The only way I don't have a "ni_upload_sw_state failed" is by let=
ting
pi->voltage_control =3D radeon_atom_is_voltage_gpio(rdev,
SET_VOLTAGE_TYPE_ASIC_VDDC, 0); However, I inevitably end up with a hang ei=
ther
at login or when my session is loading (however, going in a terminal before=
it
hangs prevents any hang from happening as long as I stay in terminal).
If I patch that part of code, I always have the "ni_upload_sw_state fa=
iled"
error, thus not hanging but preventing any dpm.
I can patch everything else or nothing at all (I tried different combinatio=
ns)
and they don't seem to change a thing about the hang.