From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 68451] Texture flicker in native Dota2 in mesa 9.2.0rc1 Date: Thu, 10 Oct 2013 21:51:38 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0249513831==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 65905E7A8D for ; Thu, 10 Oct 2013 14:51:38 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0249513831== Content-Type: multipart/alternative; boundary="1381441898.A618ce6a0.22480"; charset="us-ascii" --1381441898.A618ce6a0.22480 Date: Thu, 10 Oct 2013 21:51:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=68451 --- Comment #34 from Alexandre Demers --- (In reply to comment #33) > (In reply to comment #27) > > fun observation: > > > > Instead of reverting, setting this at the end of r600_cp_dma_copy_buffer() > > appears to fix it for me: > > rctx->b.flags |= R600_CONTEXT_INV_VERTEX_CACHE; > > > > (R600_CONTEXT_INV_CONST_CACHE will also work) > > > > Well, if we are using CP DMA to update a constant buffer or vertex buffer, > we need to flush the the apprortiate shader read caches. So, if I understand correctly what you mean, before reverting commit 7948ed1250cae78ae1b22dbce4ab23aceacc6159, the problem was that we were not flushing correctly (read "when expected") caches. Am I understanding correctly? Why would adding either rctx->b.flags |= R600_CONTEXT_INV_VERTEX_CACHE or rctx->b.flags |= R600_CONTEXT_INV_CONST_CACHE work in fixing the texture glitch (which are coming from an unknown buffer type for now) if they are not intended for the same buffer type? Also, I'm still interested in benchmarking with and without commit 7948ed1250cae78ae1b22dbce4ab23aceacc6159, so I'll gladly run any suggestion. Would something like Phoronix test suite be of any interest? -- You are receiving this mail because: You are the assignee for the bug. --1381441898.A618ce6a0.22480 Date: Thu, 10 Oct 2013 21:51:38 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 34 on bug 68451 from 
(In reply to comment #33)
> (In reply to comment #27)
> > fun observation:
> > 
> > Instead of reverting, setting this at the end of r600_cp_dma_copy_buffer()
> > appears to fix it for me:
> >     rctx->b.flags |= R600_CONTEXT_INV_VERTEX_CACHE;
> > 
> > (R600_CONTEXT_INV_CONST_CACHE will also work)
> > 
> 
> Well, if we are using CP DMA to update a constant buffer or vertex buffer,
> we need to flush the the apprortiate shader read caches.

So, if I understand correctly what you mean, before reverting commit
7948ed1250cae78ae1b22dbce4ab23aceacc6159, the problem was that we were not
flushing correctly (read "when expected") caches. Am I understanding correctly?

Why would adding either rctx->b.flags |= R600_CONTEXT_INV_VERTEX_CACHE or
rctx->b.flags |= R600_CONTEXT_INV_CONST_CACHE work in fixing the texture glitch
(which are coming from an unknown buffer type for now) if they are not intended
for the same buffer type?

Also, I'm still interested in benchmarking with and without commit
7948ed1250cae78ae1b22dbce4ab23aceacc6159, so I'll gladly run any suggestion.
Would something like Phoronix test suite be of any interest?

You are receiving this mail because:
  • You are the assignee for the bug.
--1381441898.A618ce6a0.22480-- --===============0249513831== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0249513831==--