[Bug 69671] New: rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[Bug 69671] New: rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1210 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

          Priority: medium
            Bug ID: 69671
          Assignee: dri-devel@lists.freedesktop.org
           Summary: rv790 hdmi sound regression since fix audio dto
                    calculation on DCE3+ (v3)
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: adf.lists@gmail.com
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: XOrg CVS
         Component: DRM/Radeon
           Product: DRI

My rv790 has lost sound over hdmi since -

1518dd8efd47918bb269f1470030592875953f6c is the first bad commit
commit 1518dd8efd47918bb269f1470030592875953f6c
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Tue Jul 30 17:31:07 2013 -0400

    drm/radeon: fix audio dto calculation on DCE3+ (v3)

    Need to set the wallclock ratio and adjust the phase
    and module registers appropriately.  May fix problems
    with audio timing at certain display timings.

    v2: properly handle clocks below 24mhz
    v3: rebase r600 changes

Tested with 44,1k and 48k source, screen 50Hz.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2580 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 69671] rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

--- Comment #1 from Andy Furniss <adf.lists@gmail.com> ---
More testing shows that low Hz modes do still work - in all cases the /1.001
modes behave the same as the exacts.

50p and 60p = fail = no sound and mplayer behaves as is does if the device
isn't there = playing too fast.

24p, 25i and 30i are working OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1264 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 69671] rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 291 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

--- Comment #2 from Alex Deucher <agd5f@yahoo.com> ---
Possibly related to bug 69675?  Does reverting
e6e792092e816bea0797995c886fb057c91d4546 also fix the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1263 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 69671] rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 562 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

--- Comment #3 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to comment #2)
> Possibly related to bug 69675?  Does reverting
> e6e792092e816bea0797995c886fb057c91d4546 also fix the issue?

I may try later but TBH I can't see why it would, the new modes seem to be just
extras that don't alter the original modes or even add one in the 50Hz case and
they all work for me before 1518dd8efd47918bb269f1470030592875953f6c anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1611 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 69671] rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

--- Comment #4 from Alex Deucher <agd5f@yahoo.com> ---
Created attachment 86569
  --> https://bugs.freedesktop.org/attachment.cgi?id=86569&action=edit
possible fix

Does this patch fix the isssue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1341 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 69671] rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

--- Comment #5 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to comment #4)
> Created attachment 86569 [details] [review]
> possible fix
> 
> Does this patch fix the isssue?

Yes, all modes are working with that, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1517 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 69671] rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=69671

Alex Deucher <agd5f@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Alex Deucher <agd5f@yahoo.com> ---
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=58d327da9721f7a0f6e46c8dfa5cc5546fd7078a

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2239 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel