From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 69675] audio broken in 24Hz/24p since 3.11 (regression) Date: Sat, 02 Nov 2013 14:02:20 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0375020579==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 07061F08D6 for ; Sat, 2 Nov 2013 07:02:21 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0375020579== Content-Type: multipart/alternative; boundary="1383400940.FDfa2a3.13797"; charset="us-ascii" --1383400940.FDfa2a3.13797 Date: Sat, 2 Nov 2013 14:02:20 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=69675 --- Comment #44 from Anssi Hannula --- (In reply to comment #43) > (In reply to comment #40) > > > 1. The 25175 clock at 44.1 kHz is out of spec. There are no correct values to > > > make it in spec. So either change the clock, rely on hw calculated values, or > > > hope that sinks tolerate the large N. > > > > 4th alternative is to round CTS and leave the glitches in on those modes. I > > might even slightly prefer that than produce out-of-spec N, but that is just > > my preference and I don't really have any real-world data of course... > > If we truncate the clock to 25274 instead instead of rounding it up, we can > get sensible N/CTS. Is that something that's possible to do? I don't know > how the code that generates the clock looks like. I don't think it makes sense to massage the video clock to get integer CTS. After all, the clock can come from other sources as well (user modeline, EDID...). However, there's a similar 6th alternative: Massage the target clock frequency that is used by r600_hdmi_acr() and r600_audio_set_dto() (and evergreen_audio_set_dto()) so that an integer CTS is achieved. This will cause the CTS to be correct and in-spec, but the audio speed will be on the order of ~0.004% slower/faster than video (remember that video+audio may not be this accurate otherwise either, as pll clock may not match target clock exactly). Not sure without testing which is worse, rounted (wrong) CTS or very slightly slower/faster audio compared to video. -- You are receiving this mail because: You are the assignee for the bug. --1383400940.FDfa2a3.13797 Date: Sat, 2 Nov 2013 14:02:20 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 44 on bug 69675 from
(In reply to comment #43)
> (In reply to comment #40)
> > > 1. The 25175 clock at 44.1 kHz is out of spec. There are no correct values to
> > > make it in spec. So either change the clock, rely on hw calculated values, or
> > > hope that sinks tolerate the large N.
> > 
> > 4th alternative is to round CTS and leave the glitches in on those modes. I
> > might even slightly prefer that than produce out-of-spec N, but that is just
> > my preference and I don't really have any real-world data of course...
> 
> If we truncate the clock to 25274 instead instead of rounding it up, we can
> get sensible N/CTS. Is that something that's possible to do? I don't know
> how the code that generates the clock looks like.

I don't think it makes sense to massage the video clock to get integer CTS.
After all, the clock can come from other sources as well (user modeline,
EDID...).

However, there's a similar 6th alternative: Massage the target clock frequency
that is used by r600_hdmi_acr() and r600_audio_set_dto() (and
evergreen_audio_set_dto()) so that an integer CTS is achieved. This will cause
the CTS to be correct and in-spec, but the audio speed will be on the order of
~0.004% slower/faster than video (remember that video+audio may not be this
accurate otherwise either, as pll clock may not match target clock exactly).

Not sure without testing which is worse, rounted (wrong) CTS or very slightly
slower/faster audio compared to video.


You are receiving this mail because:
  • You are the assignee for the bug.
--1383400940.FDfa2a3.13797-- --===============0375020579== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0375020579==--