From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 70088] Glamor on r600g crashes Xserver Date: Sat, 05 Oct 2013 00:58:26 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0981584160==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 98E0FE5C4D for ; Fri, 4 Oct 2013 17:58:26 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0981584160== Content-Type: multipart/alternative; boundary="1380934706.15720.28595"; charset="us-ascii" --1380934706.15720.28595 Date: Sat, 5 Oct 2013 00:58:26 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=70088 --- Comment #7 from Vadim Girlin --- Created attachment 87148 --> https://bugs.freedesktop.org/attachment.cgi?id=87148&action=edit patch This patch should fix this issue. (In reply to comment #6) > It fixes my crash problem. Maybe code needs more checks for null values? > As always my patch is subpar, You shouldn't use it. Checking for null is not enough in this case, it may prevent segfault but generated shader code would be incorrect anyway, when we have null there it means that something is already broken. -- You are receiving this mail because: You are the assignee for the bug. --1380934706.15720.28595 Date: Sat, 5 Oct 2013 00:58:26 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 7 on bug 70088 from 
Created attachment 87148 [details] [review]
patch

This patch should fix this issue.


(In reply to comment #6)
> It fixes my crash problem. Maybe code needs more checks for null values?
> As always my patch is subpar, You shouldn't use it.

Checking for null is not enough in this case, it may prevent segfault but
generated shader code would be incorrect anyway, when we have null there it
means that something is already broken.

You are receiving this mail because:
  • You are the assignee for the bug.
--1380934706.15720.28595-- --===============0981584160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0981584160==--