From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 70088] Glamor on r600g crashes Xserver
Date: Sat, 05 Oct 2013 03:09:03 +0000 [thread overview]
Message-ID: <bug-70088-502-OGD7QVLiZb@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-70088-502@http.bugs.freedesktop.org/>
[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=70088
--- Comment #8 from Krzysztof A. Sobiecki <sobkas@gmail.com> ---
(In reply to comment #7)
> Created attachment 87148 [details] [review]
> patch
>
> This patch should fix this issue.
>
>
> (In reply to comment #6)
> > It fixes my crash problem. Maybe code needs more checks for null values?
> > As always my patch is subpar, You shouldn't use it.
>
> Checking for null is not enough in this case, it may prevent segfault but
> generated shader code would be incorrect anyway, when we have null there it
> means that something is already broken.
Yes it fixed the problem. Thank You.
When it will be pushed into git I will close this bug.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1909 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-10-05 3:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 17:26 [Bug 70088] New: Glamor on r600g crashes Xserver bugzilla-daemon
2013-10-03 17:57 ` [Bug 70088] " bugzilla-daemon
2013-10-03 18:21 ` bugzilla-daemon
2013-10-03 18:39 ` bugzilla-daemon
2013-10-03 21:07 ` bugzilla-daemon
2013-10-03 21:47 ` bugzilla-daemon
2013-10-03 21:48 ` bugzilla-daemon
2013-10-04 3:44 ` bugzilla-daemon
2013-10-05 0:58 ` bugzilla-daemon
2013-10-05 3:06 ` bugzilla-daemon
2013-10-05 3:09 ` bugzilla-daemon [this message]
2013-10-06 13:12 ` bugzilla-daemon
2013-10-13 3:34 ` bugzilla-daemon
2013-10-14 13:25 ` bugzilla-daemon
2013-10-14 16:49 ` bugzilla-daemon
2013-10-17 4:03 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-70088-502-OGD7QVLiZb@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).