[Bug 70088] New: Glamor on r600g crashes Xserver

[Bug 70088] New: Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 848 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

          Priority: medium
            Bug ID: 70088
          Assignee: dri-devel@lists.freedesktop.org
           Summary: Glamor on r600g crashes Xserver
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: sobkas@gmail.com
          Hardware: Other
            Status: NEW
           Version: git
         Component: Drivers/Gallium/r600
           Product: Mesa

Created attachment 87079
  --> https://bugs.freedesktop.org/attachment.cgi?id=87079&action=edit
Crash log

When I try to run Xserver and radeon driver with glamor accel method I get a
crash from Xserver. It happens when I'm starting blackbox or Gnome(from GDM3).
While GNOME causes crash, gdm3 works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2244 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 412 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #1 from Grigori Goronzy <greg@chown.ath.cx> ---
That looks exactly like the crash I see on PALM ASICs, too. I just didn't have
time to properly report it yet. Something is going wrong in SB's gcm phase.

This only seems to happen on certain ASICs, it works fine on TURKS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1150 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

Krzysztof A. Sobiecki <sobkas@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Other                       |x86-64 (AMD64)
                 OS|All                         |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 230 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #2 from Vadim Girlin <ptpzz@yandex.ru> ---
Please attach the output with R600_DEBUG=ps,vs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 963 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 527 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
You should be able to obtain a better backtrace if you do this:

1) Delete /etc/X11/core.
2) Reproduce the crash. This should create a new core file in /etc/X11.
3) Run: gdb /usr/bin/Xorg /etc/X11/core
4) Type bt in gdb.

The paths may differ depending on your distribution. Please attach the
backtrace you will get from gdb.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1282 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #4 from Grigori Goronzy <greg@chown.ath.cx> ---
Created attachment 87094
  --> https://bugs.freedesktop.org/attachment.cgi?id=87094&action=edit
Xorg log with shader dump and sb dump

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1225 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #5 from Grigori Goronzy <greg@chown.ath.cx> ---
Created attachment 87095
  --> https://bugs.freedesktop.org/attachment.cgi?id=87095&action=edit
Xorg backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1156 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #6 from Krzysztof A. Sobiecki <sobkas@gmail.com> ---
Created attachment 87098
  --> https://bugs.freedesktop.org/attachment.cgi?id=87098&action=edit
It fixes my crash problem

It fixes my crash problem. Maybe code needs more checks for null values?
As always my patch is subpar, You shouldn't use it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1409 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #7 from Vadim Girlin <ptpzz@yandex.ru> ---
Created attachment 87148
  --> https://bugs.freedesktop.org/attachment.cgi?id=87148&action=edit
patch

This patch should fix this issue.


(In reply to comment #6)
> It fixes my crash problem. Maybe code needs more checks for null values?
> As always my patch is subpar, You shouldn't use it.

Checking for null is not enough in this case, it may prevent segfault but
generated shader code would be incorrect anyway, when we have null there it
means that something is already broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1658 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 412 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

Krzysztof A. Sobiecki <sobkas@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87098|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1065 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #8 from Krzysztof A. Sobiecki <sobkas@gmail.com> ---
(In reply to comment #7)
> Created attachment 87148 [details] [review]
> patch
> 
> This patch should fix this issue.
> 
> 
> (In reply to comment #6)
> > It fixes my crash problem. Maybe code needs more checks for null values?
> > As always my patch is subpar, You shouldn't use it.
> 
> Checking for null is not enough in this case, it may prevent segfault but
> generated shader code would be incorrect anyway, when we have null there it
> means that something is already broken.

Yes it fixed the problem. Thank You.
When it will be pushed into git I will close this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1909 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 239 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #9 from Grigori Goronzy <greg@chown.ath.cx> ---
I can also confirm that the patch fixes the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 977 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 230 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #10 from Krzysztof A. Sobiecki <sobkas@gmail.com> ---
When Your patch will go into a git?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 974 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 617 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

Vadim Girlin <ptpzz@yandex.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87148|0                           |1
        is obsolete|                            |

--- Comment #11 from Vadim Girlin <ptpzz@yandex.ru> ---
Created attachment 87597
  --> https://bugs.freedesktop.org/attachment.cgi?id=87597&action=edit
patch

This is an improved version of the patch, please test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2022 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 414 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

--- Comment #12 from Krzysztof A. Sobiecki <sobkas@gmail.com> ---
(In reply to comment #11)
> Created attachment 87597 [details] [review]
> patch
> 
> This is an improved version of the patch, please test.

Glamor acceleration with mesa + this patch works fine, will try to run piglit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1484 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 70088] Glamor on r600g crashes Xserver

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 535 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70088

Vadim Girlin <ptpzz@yandex.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Vadim Girlin <ptpzz@yandex.ru> ---
Fix pushed with commit 62c8149472903a2f3fc4d319c3799b9e729419d5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1935 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel