[Bug 70110] [bisected] regression: assert in r600_bind_sampler_states since 27c054edf0ae92c8c498830e7c7510fa94f5dcfd

[bugzilla-daemon@freedesktop.org]

[-- Attachment #1.1: Type: text/plain, Size: 1044 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70110

--- Comment #1 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
Easy one: under r600_bind_sampler_states(), there is an assert. Since I'm
building with --enable-debug, I hit it.

    if (shader != PIPE_SHADER_VERTEX &&
        shader != PIPE_SHADER_FRAGMENT) {
        assert(!"Only vertex/fragment sampler are implemented.");
        return;
    }


I suggest we should/could print out an error message if needed, but it
shouldn't be an assert() since we return just after that without doing anything
if the shader is not of the supported type. In fact, I tested mesa with the
assert commented out and everything was back to the way it used to be, so we
really don't need an assert() there. A R600_ERR() seems to do the trick here:

    if (shader != PIPE_SHADER_VERTEX &&
        shader != PIPE_SHADER_FRAGMENT) {
        R600_ERR("!Only vertex/fragment sampler are implemented.\n");
        return;
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1976 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel