From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 70169] taskbar is white when using kwin GLES Date: Tue, 08 Oct 2013 18:11:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1500812598==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id F1B6DE6FDE for ; Tue, 8 Oct 2013 11:11:30 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1500812598== Content-Type: multipart/alternative; boundary="1381255890.ED1133151.25892"; charset="us-ascii" --1381255890.ED1133151.25892 Date: Tue, 8 Oct 2013 18:11:30 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=70169 Ian Romanick changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |NOTOURBUG --- Comment #2 from Ian Romanick --- It appears that kwin's shaders are incorrect. In 9.2 we fixed a deviation from the GLSL ES specification (that is followed by numerous other vendors) that we did not require precision qualifiers for float types in the fragment shader. They just need to add: precision float; the their fragment shaders. In OpenGL ES 3.0, highp must be supported, but in ES 2.0 it is optional. See the following commit: commit cabd45773b58d6aa48202da1cdd8cf1a6b856c53 Author: Ian Romanick Date: Fri Aug 9 15:17:18 2013 -0700 glsl: Track existence of default float precision in GLSL ES fragment shaders This is required by the spec, and it's a bit tricky because the default precision is scoped. As a result, I'm slightly abusing the symbol table. Fixes piglit no-default-float-precision.frag tests and the piglit default-precision-nested-scope-0[1234].frag tests that are currently on the piglit mailing list for review. On IRC I got confirmation from cwabbot that ARM (Mali T6xx and T400) enforces this requirement and from kusma that NVIDIA (Tegra2) enforces this requirement. We should be safe from regressing shipping applications. Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke Cc: "9.2" -- You are receiving this mail because: You are the assignee for the bug. --1381255890.ED1133151.25892 Date: Tue, 8 Oct 2013 18:11:30 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 70169
What Removed Added
Status NEW RESOLVED
Resolution --- NOTOURBUG

Comment # 2 on bug 70169 from
It appears that kwin's shaders are incorrect.  In 9.2 we fixed a deviation from
the GLSL ES specification (that is followed by numerous other vendors) that we
did not require precision qualifiers for float types in the fragment shader.

They just need to add:

precision <precision of choice> float;

the their fragment shaders.  In OpenGL ES 3.0, highp must be supported, but in
ES 2.0 it is optional.

See the following commit:

commit cabd45773b58d6aa48202da1cdd8cf1a6b856c53
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Fri Aug 9 15:17:18 2013 -0700

    glsl: Track existence of default float precision in GLSL ES fragment
shaders

    This is required by the spec, and it's a bit tricky because the default
    precision is scoped.  As a result, I'm slightly abusing the symbol
    table.

    Fixes piglit no-default-float-precision.frag tests and the piglit
    default-precision-nested-scope-0[1234].frag tests that are currently on
    the piglit mailing list for review.

    On IRC I got confirmation from cwabbot that ARM (Mali T6xx and T400)
    enforces this requirement and from kusma that NVIDIA (Tegra2) enforces
    this requirement.  We should be safe from regressing shipping
    applications.

    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Cc: "9.2" <mesa-stable@lists.freedesktop.org>


You are receiving this mail because:
  • You are the assignee for the bug.
--1381255890.ED1133151.25892-- --===============1500812598== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1500812598==--