dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Bug 70327] New: Casting floating point variable to integer not working properly while constant gets converted properly
@ 2013-10-09 21:17 bugzilla-daemon
  2013-10-09 21:22 ` [Bug 70327] " bugzilla-daemon
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: bugzilla-daemon @ 2013-10-09 21:17 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1495 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=70327

          Priority: medium
            Bug ID: 70327
          Assignee: dri-devel@lists.freedesktop.org
           Summary: Casting floating point variable to integer not working
                    properly while constant gets converted properly
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: tony.wasserka@dolphin-emu.org
          Hardware: All
            Status: NEW
           Version: git
         Component: Drivers/Gallium/r600
           Product: Mesa

Created attachment 87353
  --> https://bugs.freedesktop.org/attachment.cgi?id=87353&action=edit
Full rendered scene with bug visible

I've recently been working on converting the shaders used by the Dolphin
emulator to use integers instead of floating point numbers (for better
emulation accuracy). This seems to have exposed a bug in the r600g driver
possibly related to float->int casting.

The core of the issue is this GLSL code line:
"iprev.rgb = (iprev.rgb * (int(256.0-fog))) / 256;" (*)

where fog has been initialized before as 
"float fog = clamp(ze - fog_uniform.z, 0.0, 1.0);"

The point is, while "fog" seems to be zero (a "fog==0.0" condition in the code
will return true), the pixel shader result of (*) is different than the one
that I get by substituting "fog" with 0.0. This gets very apparent in the
rendered scene, cf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3049 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-10-14  6:45 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-09 21:17 [Bug 70327] New: Casting floating point variable to integer not working properly while constant gets converted properly bugzilla-daemon
2013-10-09 21:22 ` [Bug 70327] " bugzilla-daemon
2013-10-09 21:24 ` bugzilla-daemon
2013-10-09 21:24 ` bugzilla-daemon
2013-10-09 21:30 ` bugzilla-daemon
2013-10-09 21:36 ` bugzilla-daemon
2013-10-09 21:43 ` bugzilla-daemon
2013-10-09 21:51 ` bugzilla-daemon
2013-10-09 22:16 ` bugzilla-daemon
2013-10-09 22:18 ` bugzilla-daemon
2013-10-10  1:15 ` bugzilla-daemon
2013-10-10  8:55 ` bugzilla-daemon
2013-10-14  6:45 ` bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).