From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 73191] [radeonsi] vdpau playback issues, skipping & looping Date: Mon, 24 Feb 2014 19:28:38 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1525026874==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 02011FAB5C for ; Mon, 24 Feb 2014 11:28:38 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1525026874== Content-Type: multipart/alternative; boundary="1393270118.ffCF8eaF2.19018"; charset="us-ascii" --1393270118.ffCF8eaF2.19018 Date: Mon, 24 Feb 2014 19:28:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D73191 Andreas Boll changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #42 from Andreas Boll --- Fixed with the following commits: commit 3f98053fc94a964930c73c43154daddfd7824e7c Author: Marek Ol=C5=A1=C3=A1k Date: Mon Jan 13 14:13:01 2014 +0100 vdpau: flush the context before exporting the surface v2 Bugzilla (bug needs XBMC changes as well): https://bugs.freedesktop.org/show_bug.cgi?id=3D73191 When VL uploads vertex buffers, it uses PIPE_TRANSFER_DONTBLOCK, which always flushes the context in the winsys if the buffer being mapped is busy. S= ince I added handling of DISCARD_RANGE, DONTBLOCK has had no effect when combined with DISCARD_RANGE and I think the context isn't flushed anywhere else, so no commands are submitted to the GPU until the IB is full, which tak= es a lot of frames. Using DISCARD_RANGE is not the only way to trigger this bug. The other = way is to reallocate the vertex buffer before every upload. BTW, I'm not sure if this is the right place for flushing, but it does = fix the bug. v2 (chk): move the flush to the right place. Signed-off-by: Christian K=C3=B6nig Tested-by: StrangeNoises (rachel@strangenoises.org) commit db54fca9b86aa124447d11d2bdbe359a2742cfd5 Author: Christian K=C3=B6nig Date: Tue Jan 28 15:22:05 2014 +0100 st/vdpau: add flush on unmap Flush the context when we unmap a buffer, otherwise VDPAU might start rendering the next frame while we still reference that buffer. Signed-off-by: Christian K=C3=B6nig Tested-by: StrangeNoises (rachel@strangenoises.org) Additionally cherry-picked to 10.1 branch. --=20 You are receiving this mail because: You are the assignee for the bug. --1393270118.ffCF8eaF2.19018 Date: Mon, 24 Feb 2014 19:28:38 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Andreas Boll changed bug 73191<= /a>
What Removed Added
Status NEW RESOLVED
Resolution --- FIXED

Commen= t # 42 on bug 73191<= /a> from Andreas Boll
Fixed with the following commits:

commit 3f98053fc94a964930c73c43154daddfd7824e7c
Author: Marek Ol=C5=A1=C3=A1k <marek.olsak@amd.com>
Date:   Mon Jan 13 14:13:01 2014 +0100

    vdpau: flush the context before exporting the surface v2

    Bugzilla (bug needs XBMC changes as well):
    https://bugs.freedesktop.org/show_bug.c=
gi?id=3D73191

    When VL uploads vertex buffers, it uses PIPE_TRANSFER_DONTBLOCK, which
always
    flushes the context in the winsys if the buffer being mapped is busy. S=
ince
    I added handling of DISCARD_RANGE, DONTBLOCK has had no effect when
combined
    with DISCARD_RANGE and I think the context isn't flushed anywhere else,
    so no commands are submitted to the GPU until the IB is full, which tak=
es
    a lot of frames.

    Using DISCARD_RANGE is not the only way to trigger this bug. The other =
way
    is to reallocate the vertex buffer before every upload.

    BTW, I'm not sure if this is the right place for flushing, but it does =
fix
    the bug.

    v2 (chk): move the flush to the right place.

    Signed-off-by: Christian K=C3=B6nig <christian.koenig@amd.com>
    Tested-by: StrangeNoises (rachel@strangenoises.org)


commit db54fca9b86aa124447d11d2bdbe359a2742cfd5
Author: Christian K=C3=B6nig <christian.koenig@amd.com>
Date:   Tue Jan 28 15:22:05 2014 +0100

    st/vdpau: add flush on unmap

    Flush the context when we unmap a buffer, otherwise VDPAU might
    start rendering the next frame while we still reference that buffer.

    Signed-off-by: Christian K=C3=B6nig <christian.koenig@amd.com>
    Tested-by: StrangeNoises (rachel@strangenoises.org)


Additionally cherry-picked to 10.1 branch.


You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1393270118.ffCF8eaF2.19018-- --===============1525026874== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1525026874==--