From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 73338] Fan speed in idle at 40% with radeonsi and at 18% with catalyst Date: Fri, 05 Dec 2014 20:11:12 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2020006940==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id A32286E295 for ; Fri, 5 Dec 2014 12:11:12 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2020006940== Content-Type: multipart/alternative; boundary="1417810272.feBCEed5.27661"; charset="UTF-8" --1417810272.feBCEed5.27661 Date: Fri, 5 Dec 2014 20:11:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=73338 --- Comment #65 from Chernovsky Oleg --- > 1. add the new dpm asic callbacks > 2. add the common hwmon fan code. Make sure it's only enabled on asics > which support manual fan control > 3. wire up the CI specific code Ok, makes sense > > As far as percent vs. rpm, I'm not sure which would be preferred. I think > the hwmon subsystem generally prefers rpm. Maybe add callbacks for both > percent and rpm and then check rdev->pm.fan_pulses_per_revolution. If it's > 0, expose it as a percent. if not, expose as rpm. Thoughts? Might be > worth asking on the hwmon mailing lists. Good idea, I'll try to test rpm behaviour today > Also, we should only expose these on asics which support fan control. No problem, some tinkering with `hwmon_attributes_visible` should make it. I'll refresh & update patches on weekend. -- You are receiving this mail because: You are the assignee for the bug. --1417810272.feBCEed5.27661 Date: Fri, 5 Dec 2014 20:11:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 65 on bug 73338 from 
> 1. add the new dpm asic callbacks
> 2. add the common hwmon fan code.  Make sure it's only enabled on asics
> which support manual fan control
> 3. wire up the CI specific code

Ok, makes sense

> 
> As far as percent vs. rpm, I'm not sure which would be preferred.  I think
> the hwmon subsystem generally prefers rpm.  Maybe add callbacks for both
> percent and rpm and then check rdev->pm.fan_pulses_per_revolution.  If it's
> 0, expose it as a percent.  if not, expose as rpm.  Thoughts?  Might be
> worth asking on the hwmon mailing lists.

Good idea, I'll try to test rpm behaviour today

> Also, we should only expose these on asics which support fan control.

No problem, some tinkering with `hwmon_attributes_visible` should make it.

I'll refresh & update patches on weekend.

You are receiving this mail because:
  • You are the assignee for the bug.
--1417810272.feBCEed5.27661-- --===============2020006940== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============2020006940==--