[Bug 73338] Fan speed in idle at 40% with radeonsi and at 18% with catalyst

[bugzilla-daemon@freedesktop.org]

[-- Attachment #1.1: Type: text/plain, Size: 1147 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=73338

--- Comment #64 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Chernovsky Oleg from comment #63)
> Created attachment 110476 [details] [review]
> hwmon interface for manual fan control on CI cards
> 
> Hi Alex, I've made rough patch implementing hwmon interface for the code
> you've provided. Please take a look (comments inside).
> 
> Patch is done on top of your 3.19-wip branch.

Looks good.  Please split into 3 patches:

1. add the new dpm asic callbacks
2. add the common hwmon fan code.  Make sure it's only enabled on asics which
support manual fan control
3. wire up the CI specific code

As far as percent vs. rpm, I'm not sure which would be preferred.  I think the
hwmon subsystem generally prefers rpm.  Maybe add callbacks for both percent
and rpm and then check rdev->pm.fan_pulses_per_revolution.  If it's 0, expose
it as a percent.  if not, expose as rpm.  Thoughts?  Might be worth asking on
the hwmon mailing lists.

Also, we should only expose these on asics which support fan control.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2375 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel