From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 73338] Fan speed in idle at 40% with radeonsi and at 18% with catalyst Date: Fri, 05 Dec 2014 19:16:28 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0489343999==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D5906E6F8 for ; Fri, 5 Dec 2014 11:16:29 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0489343999== Content-Type: multipart/alternative; boundary="1417806989.fabB7b35.4071"; charset="UTF-8" --1417806989.fabB7b35.4071 Date: Fri, 5 Dec 2014 19:16:29 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=73338 --- Comment #64 from Alex Deucher --- (In reply to Chernovsky Oleg from comment #63) > Created attachment 110476 [details] [review] > hwmon interface for manual fan control on CI cards > > Hi Alex, I've made rough patch implementing hwmon interface for the code > you've provided. Please take a look (comments inside). > > Patch is done on top of your 3.19-wip branch. Looks good. Please split into 3 patches: 1. add the new dpm asic callbacks 2. add the common hwmon fan code. Make sure it's only enabled on asics which support manual fan control 3. wire up the CI specific code As far as percent vs. rpm, I'm not sure which would be preferred. I think the hwmon subsystem generally prefers rpm. Maybe add callbacks for both percent and rpm and then check rdev->pm.fan_pulses_per_revolution. If it's 0, expose it as a percent. if not, expose as rpm. Thoughts? Might be worth asking on the hwmon mailing lists. Also, we should only expose these on asics which support fan control. -- You are receiving this mail because: You are the assignee for the bug. --1417806989.fabB7b35.4071 Date: Fri, 5 Dec 2014 19:16:29 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 64 on bug 73338 from 
(In reply to Chernovsky Oleg from comment #63)
> Created attachment 110476 [details] [review] [review]
> hwmon interface for manual fan control on CI cards
> 
> Hi Alex, I've made rough patch implementing hwmon interface for the code
> you've provided. Please take a look (comments inside).
> 
> Patch is done on top of your 3.19-wip branch.

Looks good.  Please split into 3 patches:

1. add the new dpm asic callbacks
2. add the common hwmon fan code.  Make sure it's only enabled on asics which
support manual fan control
3. wire up the CI specific code

As far as percent vs. rpm, I'm not sure which would be preferred.  I think the
hwmon subsystem generally prefers rpm.  Maybe add callbacks for both percent
and rpm and then check rdev->pm.fan_pulses_per_revolution.  If it's 0, expose
it as a percent.  if not, expose as rpm.  Thoughts?  Might be worth asking on
the hwmon mailing lists.

Also, we should only expose these on asics which support fan control.

You are receiving this mail because:
  • You are the assignee for the bug.
--1417806989.fabB7b35.4071-- --===============0489343999== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0489343999==--