[Bug 75061] bug in clearing color buffer

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop
                   |org                         |.org
          Component|Other                       |Drivers/Gallium/r600

--- Comment #11 from Michel Dänzer <michel@daenzer.net> ---
AFAICT the problem is that both threads access the same struct r600_resource
concurrently. It might be relatively easy to avoid the crashes by updating the
buf member atomically in r600_init_resource() instead of setting it to NULL
first in r600_invalidate_buffer(), but I suspect there could be more subtle
issues with other members, in particular valid_buffer_range.

Marek, any thoughts on how to solve this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2366 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 575 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

--- Comment #12 from Marek Olšák <maraeo@gmail.com> ---
All writes to valid_buffer_range are protected by a mutex. Only the reads are
not.

I've got no idea what to do with invalidate_buffer. If we added mutexes
everywhere, it would slow down the driver.

I think that calling BufferData in one thread and using the buffer for
rendering in some other thread is a race condition in the application and
should be fixed in the app.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1325 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 843 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

--- Comment #13 from Marek Olšák <maraeo@gmail.com> ---
If the program called MapBufferRange(MAP_INVALIDATE_BUFFER_BIT) instead of
BufferData, I think it would be okay to crash:

>From GL 4.4 spec:

"MAP_INVALIDATE_BUFFER_BIT indicates that the previous contents of the entire
buffer may be discarded. Data within the entire buffer are undefined with the
exception of subsequently written data. No GL error is generated if subsequent
GL operations access unwritten data, but the result is undefined and system
errors (possibly including program termination) may occur."

In other words, no context should access the buffer until UnmapBuffer() is
complete, because there may be unwritten data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1603 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94321|0                           |1
        is obsolete|                            |

--- Comment #14 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 95375
  --> https://bugs.freedesktop.org/attachment.cgi?id=95375&action=edit
possible fix

Could you please try this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2072 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 651 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95375|0                           |1
        is obsolete|                            |

--- Comment #15 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 95378
  --> https://bugs.freedesktop.org/attachment.cgi?id=95378&action=edit
possible fix 2

Please test this one. The previous patch wasn't correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2102 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 301 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

--- Comment #16 from Maxim <ya.maxis11@yandex.ru> ---
I'm sorry that I leave this bug. Just read comment 13 and realized that it was
my fault. Do I need to test this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1067 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 212 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

--- Comment #17 from Vedran Miletić <vedran@miletic.net> ---
Was this fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 954 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 75061] bug in clearing color buffer

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 841 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=75061

GitLab Migration User <gitlab-migration@fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #18 from GitLab Migration User <gitlab-migration@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/495.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2377 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel