dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 80683] New: EDID valid check ignores errors in CEA blocks
Date: Sun, 29 Jun 2014 17:41:39 +0000	[thread overview]
Message-ID: <bug-80683-502@http.bugs.freedesktop.org/> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1314 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80683

          Priority: medium
            Bug ID: 80683
          Assignee: dri-devel@lists.freedesktop.org
           Summary: EDID valid check ignores errors in CEA blocks
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: stefan.bruens@rwth-aachen.de
          Hardware: Other
            Status: NEW
           Version: DRI CVS
         Component: DRM/other
           Product: DRI

in linux/drivers/gpu/drm/drm_edid.c:

bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid)
{
...
        if (csum) {
                if (print_bad_edid) {
                        DRM_ERROR("EDID checksum is invalid, remainder is
%d\n", csum);
                }

                /* allow CEA to slide through, switches mangle this */
                if (raw_edid[0] != 0x02)
                        goto bad;
        }
...
        return true;
---

i.e. CEA blocks are always reported as valid.

This occurs frequently for me with a Radeon 7750 and a Dell U2713HM connected
via DisplayPort, the I2C-over-AUX seems to be buggy and swallows single bytes.

If I change the "return true;" to "return !csum;" bad transfers are retried.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2645 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2014-06-29 17:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-29 17:41 bugzilla-daemon [this message]
2019-10-14 13:20 ` [Bug 80683] EDID valid check ignores errors in CEA blocks bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-80683-502@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox