From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] New: I2C-over-AUX drops single bytes Date: Sun, 29 Jun 2014 18:09:20 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0063468052==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id AA77C6E146 for ; Sun, 29 Jun 2014 11:09:20 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0063468052== Content-Type: multipart/alternative; boundary="1404065360.8Ff5fAE0.13607"; charset="us-ascii" --1404065360.8Ff5fAE0.13607 Date: Sun, 29 Jun 2014 18:09:20 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D80684 Priority: medium Bug ID: 80684 Assignee: dri-devel@lists.freedesktop.org Summary: I2C-over-AUX drops single bytes Severity: normal Classification: Unclassified OS: All Reporter: stefan.bruens@rwth-aachen.de Hardware: Other Status: NEW Version: DRI CVS Component: DRM/Radeon Product: DRI I get frequent errors for the EDID checksum, obviously single bytes are dro= pped from the EDID. Good EDID: Raw EDID: 02 03 1d f1 50 90 05 04 03 02 07 16 01 06 11 12 15 13 14 1f 20 23 09 7f 07 83 01 00 00 02 3a 80 18 71 38 2d 40 58 2c 25 00 55 50 21 00 00 1e 01 1d 80 18 71 1c 16 20 58 2c 25 00 55 50 21 00 00 <--=20 9e 01 1d 00 72 51 d0 1e 20 6e 28 55 00 55 50 21 00 00 1e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 55 50 21 00 00 18 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 5d Bad EDID example: Raw EDID: 02 03 1d f1 50 90 05 04 03 02 07 16 01 06 11 12 15 13 14 1f 20 23 09 7f 07 83 01 00 00 02 3a 80 18 71 38 2d 40 58 2c 25 00 55 50 21 00 00 1e 01 1d 80 18 1c 16 20 58 2c 25 00 55 50 21 00 00 9e <-- 0x71 is missing 01 1d 00 72 51 d0 1e 20 6e 28 55 00 55 50 21 00 00 1e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 55 50 21 00 00 18 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 5d 00 The position of the dropped byte changes, sometimes the EDID is complete, sometimes several bytes are dropped. The bad EDIDs are *often* accompanied with [drm:radeon_process_aux_ch] dp_aux_ch flags not zero messages. Most probably the common i2c-over-aux code drops the byte, as it starts the transfer again in case of -EBUSY. If I change radeon_process_aux_ch to retu= rn -EIO in case of (ReplyStatus =3D=3D 2), I no longer have any bad checksums. Hardware is Radeon 7750 + Dell U2713HM, connected via DP. Same monitor with Intel Haswell and different cable works without any error= s. Kernel is 3.15.1, i.e. without the i2c bus mutex, dont know if this fixes t= he problems as well.=1B --=20 You are receiving this mail because: You are the assignee for the bug. --1404065360.8Ff5fAE0.13607 Date: Sun, 29 Jun 2014 18:09:20 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Priority medium
Bug ID 80684
Assignee dri-devel@lists.freedesktop.org
Summary I2C-over-AUX drops single bytes
Severity normal
Classification Unclassified
OS All
Reporter stefan.bruens@rwth-aachen.de
Hardware Other
Status NEW
Version DRI CVS
Component DRM/Radeon
Product DRI

I get frequent errors for the EDID checksum, obviously single =
bytes are dropped
from the EDID.

Good EDID:
Raw EDID:
      02 03 1d f1 50 90 05 04 03 02 07 16 01 06 11 12
      15 13 14 1f 20 23 09 7f 07 83 01 00 00 02 3a 80
      18 71 38 2d 40 58 2c 25 00 55 50 21 00 00 1e 01
      1d 80 18 71 1c 16 20 58 2c 25 00 55 50 21 00 00 <--=20
      9e 01 1d 00 72 51 d0 1e 20 6e 28 55 00 55 50 21
      00 00 1e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 55
      50 21 00 00 18 00 00 00 00 00 00 00 00 00 00 00
      00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 5d

Bad EDID example:
Raw EDID:
      02 03 1d f1 50 90 05 04 03 02 07 16 01 06 11 12
      15 13 14 1f 20 23 09 7f 07 83 01 00 00 02 3a 80
      18 71 38 2d 40 58 2c 25 00 55 50 21 00 00 1e 01
      1d 80 18 1c 16 20 58 2c 25 00 55 50 21 00 00 9e <-- 0x71 is missing
      01 1d 00 72 51 d0 1e 20 6e 28 55 00 55 50 21 00
      00 1e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 55 50
      21 00 00 18 00 00 00 00 00 00 00 00 00 00 00 00
      00 00 00 00 00 00 00 00 00 00 00 00 00 00 5d 00

The position of the dropped byte changes, sometimes the EDID is complete,
sometimes several bytes are dropped.

The bad EDIDs are *often* accompanied with [drm:radeon_process_aux_ch]
dp_aux_ch flags not zero messages.

Most probably the common i2c-over-aux code drops the byte, as it starts the
transfer again in case of -EBUSY. If I change radeon_process_aux_ch to retu=
rn
-EIO in case of (ReplyStatus =3D=3D 2), I no longer have any bad checksums.

Hardware is Radeon 7750 + Dell U2713HM, connected via DP.

Same monitor with Intel Haswell and different cable works without any error=
s.

Kernel is 3.15.1, i.e. without the i2c bus mutex, dont know if this fixes t=
he
problems as well.=1B


You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1404065360.8Ff5fAE0.13607-- --===============0063468052== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0063468052==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] I2C-over-AUX drops single bytes Date: Sun, 29 Jun 2014 18:35:25 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1702244909==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A1DD6E166 for ; Sun, 29 Jun 2014 11:35:25 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1702244909== Content-Type: multipart/alternative; boundary="1404066925.cdB330.21045"; charset="us-ascii" --1404066925.cdB330.21045 Date: Sun, 29 Jun 2014 18:35:25 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D80684 --- Comment #1 from Stefan Br=C3=BCns --- I have added the i2c bus mutex, this does *not* fix this bug. --=20 You are receiving this mail because: You are the assignee for the bug. --1404066925.cdB330.21045 Date: Sun, 29 Jun 2014 18:35:25 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Comment= # 1 on bug 80684<= /a> from Stefan Br=C3=BCns
I have added the i2c bus mutex, this does *not* fix this bug.<=
/pre>
        


You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1404066925.cdB330.21045-- --===============1702244909== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1702244909==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] I2C-over-AUX drops single bytes Date: Tue, 01 Jul 2014 16:00:29 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1653940626==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id C77CE6E0FE for ; Tue, 1 Jul 2014 09:00:29 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1653940626== Content-Type: multipart/alternative; boundary="1404230429.f4B8D61.22952"; charset="us-ascii" --1404230429.f4B8D61.22952 Date: Tue, 1 Jul 2014 16:00:29 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=80684 --- Comment #2 from Alex Deucher --- Created attachment 102076 --> https://bugs.freedesktop.org/attachment.cgi?id=102076&action=edit possible fix Does this patch help? -- You are receiving this mail because: You are the assignee for the bug. --1404230429.f4B8D61.22952 Date: Tue, 1 Jul 2014 16:00:29 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 2 on bug 80684 from
Created attachment 102076 [details] [review]
possible fix

Does this patch help?


You are receiving this mail because:
  • You are the assignee for the bug.
--1404230429.f4B8D61.22952-- --===============1653940626== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1653940626==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] I2C-over-AUX drops single bytes Date: Wed, 02 Jul 2014 23:19:37 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2115586637==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 32F676E66C for ; Wed, 2 Jul 2014 16:19:37 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2115586637== Content-Type: multipart/alternative; boundary="1404343177.bB552fac0.25402"; charset="us-ascii" --1404343177.bB552fac0.25402 Date: Wed, 2 Jul 2014 23:19:37 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D80684 Stefan Br=C3=BCns changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102076|0 |1 is obsolete| | --- Comment #3 from Stefan Br=C3=BCns --- Created attachment 102173 --> https://bugs.freedesktop.org/attachment.cgi?id=3D102173&action=3Dedit different approach This patch fixes the problem for me. I get several warning messages with "f= lags not zero", but the EDID is complete and correct. --=20 You are receiving this mail because: You are the assignee for the bug. --1404343177.bB552fac0.25402 Date: Wed, 2 Jul 2014 23:19:37 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Stefan Br=C3=BCns changed bug 80684<= /a>
What Removed Added
Attachment #102076 is obsolete   1

Comment= # 3 on bug 80684<= /a> from Stefan Br=C3=BCns
Created attachment 102173=
 [details] [review]
different approach

This patch fixes the problem for me. I get several warning messages with &q=
uot;flags
not zero", but the EDID is complete and correct.


You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1404343177.bB552fac0.25402-- --===============2115586637== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2115586637==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] I2C-over-AUX drops single bytes Date: Wed, 02 Jul 2014 23:22:21 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1857408139==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B5526E66F for ; Wed, 2 Jul 2014 16:22:21 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1857408139== Content-Type: multipart/alternative; boundary="1404343341.2Baf50.26348"; charset="us-ascii" --1404343341.2Baf50.26348 Date: Wed, 2 Jul 2014 23:22:21 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D80684 --- Comment #4 from Stefan Br=C3=BCns --- (In reply to comment #2) > Created attachment 102076 [details] [review] > possible fix >=20 > Does this patch help? Nope, unfortunately not. The transfer has actually worked, even with nonzero flags. *if* we want to start the transfer again, we have to set the offset before doing so. --=20 You are receiving this mail because: You are the assignee for the bug. --1404343341.2Baf50.26348 Date: Wed, 2 Jul 2014 23:22:21 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Comment= # 4 on bug 80684<= /a> from Stefan Br=C3=BCns
(In reply to comment #2=
)
> Created at=
tachment 102076 [details] [review] [review]
> possible fix
>=20
> Does this patch help?

Nope, unfortunately not.

The transfer has actually worked, even with nonzero flags. *if* we want to
start the transfer again, we have to set the offset before doing so.


You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1404343341.2Baf50.26348-- --===============1857408139== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1857408139==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] I2C-over-AUX drops single bytes Date: Thu, 03 Jul 2014 15:23:44 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1679281849==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 429AD6E2AE for ; Thu, 3 Jul 2014 08:23:44 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1679281849== Content-Type: multipart/alternative; boundary="1404401024.a77DeFe1.19287"; charset="us-ascii" --1404401024.a77DeFe1.19287 Date: Thu, 3 Jul 2014 15:23:44 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=80684 --- Comment #5 from Alex Deucher --- Created attachment 102203 --> https://bugs.freedesktop.org/attachment.cgi?id=102203&action=edit return -EIO for flags not zero Thinking about this more, I think returning -EIO is probably the right thing to do since we don't know for sure whether the transaction succeeded or not. -- You are receiving this mail because: You are the assignee for the bug. --1404401024.a77DeFe1.19287 Date: Thu, 3 Jul 2014 15:23:44 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 5 on bug 80684 from
Created attachment 102203 [details] [review]
return -EIO for flags not zero

Thinking about this more, I think returning -EIO is probably the right thing to
do since we don't know for sure whether the transaction succeeded or not.


You are receiving this mail because:
  • You are the assignee for the bug.
--1404401024.a77DeFe1.19287-- --===============1679281849== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1679281849==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80684] I2C-over-AUX drops single bytes Date: Wed, 20 Nov 2019 08:05:16 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1787711887==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id DDDBD6E288 for ; Wed, 20 Nov 2019 08:05:17 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1787711887== Content-Type: multipart/alternative; boundary="15742371170.ae8E77e.3224" Content-Transfer-Encoding: 7bit --15742371170.ae8E77e.3224 Date: Wed, 20 Nov 2019 08:05:17 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D80684 Martin Peres changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --=20 You are receiving this mail because: You are the assignee for the bug.= --15742371170.ae8E77e.3224 Date: Wed, 20 Nov 2019 08:05:17 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated <= span class=3D"fn">Martin Peres changed bug 80684<= /a>
What Removed Added
Resolution --- MOVED
Status NEW RESOLVED


You are receiving this mail because:
  • You are the assignee for the bug.
= --15742371170.ae8E77e.3224-- --===============1787711887== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1787711887==--