Commen=
t # 16
on bug 82828<=
/a>
from Marek Ol=C5=A1=C3=A1k
(In reply to comment #=
14)
> (In reply to comment #13)
> > (In reply to comment #12<=
/a>)
> > > Created attachment 105=
630 [details] [review] [review] [re=
view] [review]
> > > another debugging patch
> > >=20
> > > Ok, it looks like the problem is that node 0's q_total is bo=
gus, which means
> > > it never even gets considered for optimistic coloring. To he=
lp me figure out
> > > why this is, can you apply this patch to master (not on top =
of the other
> > > patch) and tell me the output of the piglit test now?
> >=20
> > On (In reply to comment #=
12)
> > > Created attachment 105=
630 [details] [review] [review] [re=
view] [review]
> > > another debugging patch
> > >=20
> > > Ok, it looks like the problem is that node 0's q_total is bo=
gus, which means
> > > it never even gets considered for optimistic coloring. To he=
lp me figure out
> > > why this is, can you apply this patch to master (not on top =
of the other
> > > patch) and tell me the output of the piglit test now?
> >=20
> > I'm not sure if this matters, but r300g pre-allocates the input r=
egisters
> > before calling ra_allocate_no_spills().
>=20
> I think there are no input registers in this case (there's a NumInputs=
=3D 0
> somewhere in the backtrace) so there aren't any pre-allocated nodes he=
re.
What Tom probably meant is that inputs are loaded to temps before the fragm=
ent
shader starts, so inputs and temps pretty much share the temporary file. Not
sure how relevant it is to this issue, but obviously you can't rename the t=
emps
which are supposed to contain inputs.