From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 82889] [drm:si_dpm_set_power_state] *ERROR* si_disable_ulv failed Date: Tue, 14 Oct 2014 05:05:33 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1119155799==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id D78BA6E078 for ; Mon, 13 Oct 2014 22:05:32 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1119155799== Content-Type: multipart/alternative; boundary="1413263132.8bae31.10891"; charset="UTF-8" --1413263132.8bae31.10891 Date: Tue, 14 Oct 2014 05:05:32 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=82889 --- Comment #18 from Alexandre Demers --- (In reply to Alex Deucher from comment #17) > Created attachment 107784 [details] [review] > disable ulv state on SI > > (In reply to Alexandre Demers from comment #16) > > Alex, I think this "ERROR" should be at most a warning: I've been commenting > > out the "return ret" when we hit the error, and everything else goes as > > smooth as possible. > > > > Also, do you have any clue on the way we should dig to understand why we are > > hitting this error? As said by Samir, this appeared with dpm. > > It's part of dpm so it only happens when dpm is enabled. ulv is a special > low power state the card can go to in certain idle cases. > > Does the attached patch help? I changed yet again my card and I'm now running a R9 280X. I'll put the old card in tomorrow to have a look at it. So ulv is a feature available on both APUs and 7950 (and some other GPUs). Nice to know. But is ulv support truly supposed to be available on Tahiti? In fact, prior to your patch, why is there already a comment "/* XXX disable for A0 tahiti */" in drivers/gpu/drm/radeon/si_dpm.c but ulv.supported is set to true anyway just on the next line (the one you propose to change in your patch)? To me, it's like saying a thing and doing exactly the opposite at the same time, isn't it? Or is it because there is a special case (Tahiti) that we should be addressing identified by the comment that we are not? -- You are receiving this mail because: You are the assignee for the bug. --1413263132.8bae31.10891 Date: Tue, 14 Oct 2014 05:05:32 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 18 on bug 82889 from 
(In reply to Alex Deucher from comment #17)
> Created attachment 107784 [details] [review] [review]
> disable ulv state on SI
> 
> (In reply to Alexandre Demers from comment #16)
> > Alex, I think this "ERROR" should be at most a warning: I've been commenting
> > out the "return ret" when we hit the error, and everything else goes as
> > smooth as possible.
> > 
> > Also, do you have any clue on the way we should dig to understand why we are
> > hitting this error? As said by Samir, this appeared with dpm.
> 
> It's part of dpm so it only happens when dpm is enabled.  ulv is a special
> low power state the card can go to in certain idle cases.
> 
> Does the attached patch help?

I changed yet again my card and I'm now running a R9 280X. I'll put the old
card in tomorrow to have a look at it.

So ulv is a feature available on both APUs and 7950 (and some other GPUs). Nice
to know.

But is ulv support truly supposed to be available on Tahiti? In fact, prior to
your patch, why is there already a comment "/* XXX disable for A0 tahiti */" in
drivers/gpu/drm/radeon/si_dpm.c but ulv.supported is set to true anyway just on
the next line (the one you propose to change in your patch)? To me, it's like
saying a thing and doing exactly the opposite at the same time, isn't it? Or is
it because there is a special case (Tahiti) that we should be addressing
identified by the comment that we are not?

You are receiving this mail because:
  • You are the assignee for the bug.
--1413263132.8bae31.10891-- --===============1119155799== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1119155799==--