dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components
Date: Sun, 02 Nov 2014 11:19:08 +0000	[thread overview]
Message-ID: <bug-85579-502-noQ2RS2Lxi@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-85579-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1225 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #9 from Marek Olšák <maraeo@gmail.com> ---
I think there are 2 ways to fix this and we should do both:

1) Fix VGPR register spilling caused by indirect addressing into lots of
registers. LLVM crashes when it attempts to do that. Those registers are just
copies of shader inputs and outputs.

2)
Step A) Implement indirect addressing for VS outputs before GS and GS inputs.
This means that we cannot store outputs at the end of shaders (using
emit_epilogue), but we must store them when they occur as a destination
register (using emit_store).

(BTW my tessellation branch contains modifications to emit_store that make it
easier to re-implement it for shaders that use store instructions for outputs)

Step B) glsl_to_tgsi and/or some passes of the GLSL compiler may need to be
modified not to move ins/outs into temporaries. I think the only pass that does
that is the varying packing. The pass should be disabled or rewritten, because
its current implementation isn't gonna fly with our hardware and is often the
cause of unnecessary register spilling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2086 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2014-11-02 11:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29  1:11 [Bug 85579] New: [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components bugzilla-daemon
2014-10-29  1:11 ` [Bug 85579] " bugzilla-daemon
2014-10-29  8:43 ` bugzilla-daemon
2014-10-29 12:34 ` bugzilla-daemon
2014-10-29 14:52 ` bugzilla-daemon
2014-10-29 19:52 ` bugzilla-daemon
2014-10-30  3:08 ` bugzilla-daemon
2014-10-30  3:30 ` bugzilla-daemon
2014-10-30  3:33 ` bugzilla-daemon
2014-11-02 11:19 ` bugzilla-daemon [this message]
2017-05-24  8:06 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-85579-502-noQ2RS2Lxi@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox