From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 88209] HAVE_LLVM undelcared in r600_pipe_common.c if enable_r600_llvm not set Date: Fri, 09 Jan 2015 14:25:34 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2122037095==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id EF9DE8A005 for ; Fri, 9 Jan 2015 06:25:33 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2122037095== Content-Type: multipart/alternative; boundary="1420813533.28fC0.30972"; charset="UTF-8" --1420813533.28fC0.30972 Date: Fri, 9 Jan 2015 14:25:33 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=88209 --- Comment #3 from athomas@synexxus.com --- The patch seems to be in the right direction of removing the dependance of LLVM in the source code, but I dont have hardware to test functionality. I can test that it compiles when LLVM isn't specified on Monday. I don't have enough knowledge on the internal workings of the driver to make comments on the implications of the code chages though. A couple of notes I meant to add last night: Build Environment: - Building directly on an ARM platform. imx6 - very similar to sabrelite. - I set the prefix to be someplace in my /home directory via the X.org build.sh script. - Flags: --enable-driglx-direct --enable-gles1 --enable-gles2 --enable-glx --with-dri-drivers=radeon Additional notes about the mesa build with llvm: Normally the auto setting for enable_gallium_llvm will set enable_gallium=llvm=yes and trigger llvm to be used with the driver. This is NOT the case if the host CPU is not i*86/x96_64/AMD64. See the current snippet below from configure.ac if test "x$enable_gallium_llvm" = xauto; then case "$host_cpu" in i*86|x86_64|amd64) enable_gallium_llvm=yes;; esac fi Tests I did: - I hacked the configure.ac to always set enable_gallium_llvm=yes and was able to get the gallium r600 driver to build and subsquently mesa. - I, somewhat stupidly, tested --with-dri-drivers=nouveau and not --with-gallium-drivers=nouveau because I dont care about the drivers - I will end up using Freescale/Vivante drivers. BUT - can the two be aligned or at least checked for inconsistencies. Questions: - Does it make sense to migrate the default to use LLVM for ARM platforms? At the end of the day I didnt really care about the drivers themselves because I will be dropping in Vivante drivers via Freescale, but I needed mesa/gallium to build. I should have cut the gallium drivers out, but I was concerned I had my build environment/paths setup correctly. -- You are receiving this mail because: You are the assignee for the bug. --1420813533.28fC0.30972 Date: Fri, 9 Jan 2015 14:25:33 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 3 on bug 88209 from 
The patch seems to be in the right direction of removing the dependance of 
LLVM in the source code, but I dont have hardware to test functionality. I can
test that it compiles when LLVM isn't specified on Monday. I don't have enough 
knowledge on the internal workings of the driver to make comments on the
implications of the code chages though. 

A couple of notes I meant to add last night:

Build Environment:

- Building directly on an ARM platform. imx6 - very similar to sabrelite.
- I set the prefix to be someplace in my /home directory via the X.org build.sh
script.
- Flags: --enable-driglx-direct --enable-gles1 --enable-gles2 --enable-glx
--with-dri-drivers=radeon

Additional notes about the mesa build with llvm:

Normally the auto setting for enable_gallium_llvm will set
enable_gallium=llvm=yes and trigger llvm to be used with the driver. This is
NOT the case if the host CPU is not i*86/x96_64/AMD64. See the current snippet
below from configure.ac


if test "x$enable_gallium_llvm" = xauto; then
    case "$host_cpu" in
    i*86|x86_64|amd64) enable_gallium_llvm=yes;;
    esac
fi

Tests I did:
- I hacked the configure.ac to always set enable_gallium_llvm=yes and was able
to get the gallium r600 driver to build and subsquently mesa. 
- I, somewhat stupidly, tested --with-dri-drivers=nouveau and not
--with-gallium-drivers=nouveau because I dont care about the drivers - I will
end up using Freescale/Vivante drivers. BUT - can the two be aligned or at
least checked for inconsistencies.

Questions:
- Does it make sense to migrate the default to use LLVM for ARM platforms? 

At the end of the day I didnt really care about the drivers themselves because
I will be dropping in Vivante drivers via Freescale, but I needed mesa/gallium
to build. I should have cut the gallium drivers out, but I was concerned I had
my build environment/paths setup correctly.

You are receiving this mail because:
  • You are the assignee for the bug.
--1420813533.28fC0.30972-- --===============2122037095== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============2122037095==--