From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 88493] No hdmi audio an agd5f 3.20-wip since consolidate audio_get_pin() functions Date: Mon, 02 Feb 2015 21:50:43 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0638183504==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E0156E045 for ; Mon, 2 Feb 2015 13:50:43 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0638183504== Content-Type: multipart/alternative; boundary="1422913843.a6aab8B0.18160"; charset="UTF-8" --1422913843.a6aab8B0.18160 Date: Mon, 2 Feb 2015 21:50:43 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=88493 --- Comment #10 from Andy Furniss --- (In reply to Alex Deucher from comment #1) > Are you sure that's the right commit? I don't see any functional change. > It just switches a direct function call to a function pointer. I played a bit more - trying to see if there was any real change or maybe some unlucky h/w timing/order issue. There is a functional change, I guess seeded in a preceding commit. Testing with debugging like - diff --git a/drivers/gpu/drm/radeon/dce6_afmt.c b/drivers/gpu/drm/radeon/dce6_afmt.c index 96f298c..266f32a 100644 --- a/drivers/gpu/drm/radeon/dce6_afmt.c +++ b/drivers/gpu/drm/radeon/dce6_afmt.c @@ -75,6 +75,7 @@ struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev) { int i; + DRM_ERROR("[ADF] in dce6_audio_get_pin\n"); dce6_afmt_get_connected_pins(rdev); for (i = 0; i < rdev->audio.num_pins; i++) { On the bad commit there is no output after doing xrandr --output HDMI-0 --auto on the commit before there is. On the bad I do get the output with a second use of xrandr. -- You are receiving this mail because: You are the assignee for the bug. --1422913843.a6aab8B0.18160 Date: Mon, 2 Feb 2015 21:50:43 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 10 on bug 88493 from 
(In reply to Alex Deucher from comment #1)
> Are you sure that's the right commit?  I don't see any functional change. 
> It just switches a direct function call to a function pointer.

I played a bit more - trying to see if there was any real change or maybe some
unlucky h/w timing/order issue.

There is a functional change, I guess seeded in a preceding commit.

Testing with debugging like -

diff --git a/drivers/gpu/drm/radeon/dce6_afmt.c
b/drivers/gpu/drm/radeon/dce6_afmt.c
index 96f298c..266f32a 100644
--- a/drivers/gpu/drm/radeon/dce6_afmt.c
+++ b/drivers/gpu/drm/radeon/dce6_afmt.c
@@ -75,6 +75,7 @@ struct r600_audio_pin *dce6_audio_get_pin(struct
radeon_device *rdev)
 {
        int i;

+        DRM_ERROR("[ADF] in dce6_audio_get_pin\n");
        dce6_afmt_get_connected_pins(rdev);

        for (i = 0; i < rdev->audio.num_pins; i++) {

On the bad commit there is no output after doing 

xrandr --output HDMI-0 --auto 

on the commit before there is.

On the bad I do get the output with a second use of xrandr.

You are receiving this mail because:
  • You are the assignee for the bug.
--1422913843.a6aab8B0.18160-- --===============0638183504== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0638183504==--