From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 89069] Lack of grass in The Talos Principle on radeonsi (native\wine\nine) Date: Mon, 04 May 2015 22:47:59 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2119668301==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 97C2A6E04E for ; Mon, 4 May 2015 15:47:59 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2119668301== Content-Type: multipart/alternative; boundary="1430779679.d08c251.8033"; charset="UTF-8" --1430779679.d08c251.8033 Date: Mon, 4 May 2015 22:47:59 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=89069 --- Comment #34 from Daniel Scharrer --- (In reply to smoki from comment #28) > After > http://cgit.freedesktop.org/mesa/mesa/commit/ > ?id=c6d79ed289a75f13c65f011be870f7e43a0fedc7 which improve code quality i > can enable unsafe-fp-math and grass is now there with trace from Comment 7 > > Daniel and others, you might want to recheck this. I can confirm that there is still grass with Mesa git-e1ae0c3 + LLVM r236436 and diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c.old b/src/gallium/drivers/radeon/radeon_llvm_emit.c index 624077c..0f9dbab 100644 --- a/src/gallium/drivers/radeon/radeon_llvm_emit.c.old +++ b/src/gallium/drivers/radeon/radeon_llvm_emit.c @@ -80,6 +80,10 @@ void radeon_llvm_shader_type(LLVMValueRef F, unsigned type) sprintf(Str, "%1d", llvm_type); LLVMAddTargetDependentFunctionAttr(F, "ShaderType", Str); + + if (type != TGSI_PROCESSOR_COMPUTE) { + LLVMAddTargetDependentFunctionAttr(F, "unsafe-fp-math", "true"); + } } I still get GPU faults with The Talos Principle, even with "unsafe-fp-math" enabled now - although not with either of the traces I posted. I also get some garbage rendered / flickering stuff, but I don't think it's related to "unsafe-fp-math". I'll test more and post a new trace when I have time. -- You are receiving this mail because: You are the assignee for the bug. --1430779679.d08c251.8033 Date: Mon, 4 May 2015 22:47:59 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 34 on bug 89069 from 
(In reply to smoki from comment #28)
>  After
> http://cgit.freedesktop.org/mesa/mesa/commit/
> ?id=c6d79ed289a75f13c65f011be870f7e43a0fedc7 which improve code quality i
> can enable unsafe-fp-math and grass is now there with trace from Comment 7
> 
>  Daniel and others, you might want to recheck this.

I can confirm that there is still grass with Mesa git-e1ae0c3 + LLVM r236436
and

diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c.old
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index 624077c..0f9dbab 100644
--- a/src/gallium/drivers/radeon/radeon_llvm_emit.c.old
+++ b/src/gallium/drivers/radeon/radeon_llvm_emit.c
@@ -80,6 +80,10 @@ void radeon_llvm_shader_type(LLVMValueRef F, unsigned type)
        sprintf(Str, "%1d", llvm_type);

        LLVMAddTargetDependentFunctionAttr(F, "ShaderType", Str);
+
+       if (type != TGSI_PROCESSOR_COMPUTE) {
+               LLVMAddTargetDependentFunctionAttr(F, "unsafe-fp-math",
"true");
+       }
 }

I still get GPU faults with The Talos Principle, even with "unsafe-fp-math"
enabled now - although not with either of the traces I posted. I also get some
garbage rendered / flickering stuff, but I don't think it's related to
"unsafe-fp-math". I'll test more and post a new trace when I have time.

You are receiving this mail because:
  • You are the assignee for the bug.
--1430779679.d08c251.8033-- --===============2119668301== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============2119668301==--