From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 89944] GPU crash in Civilization 5 Date: Wed, 08 Apr 2015 21:52:22 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0120509798==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 324386E71E for ; Wed, 8 Apr 2015 14:52:23 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0120509798== Content-Type: multipart/alternative; boundary="1428529942.d40D87321.26187"; charset="UTF-8" --1428529942.d40D87321.26187 Date: Wed, 8 Apr 2015 21:52:22 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=89944 Sami Liedes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth@whitecape.org --- Comment #3 from Sami Liedes --- I bisected this down to this commit: ------------------------------------------------------------ commit 30f51f1a1a70bc838d5bed449daff0dd9f2e8ef2 Author: Kenneth Graunke Date: Wed Oct 22 20:48:21 2014 -0700 glsl: Optimize "if (cond) discard;" to a conditional discard. st_glsl_to_tgsi and ir_to_mesa have handled conditional discards for a long time; the previous patch added that capability to i965. i965 (Haswell) shader-db stats: Without NIR: total instructions in shared programs: 5792133 -> 5776360 (-0.27%) instructions in affected programs: 737585 -> 721812 (-2.14%) helped: 6300 HURT: 68 GAINED: 2 With NIR: total instructions in shared programs: 5787538 -> 5769569 (-0.31%) instructions in affected programs: 767843 -> 749874 (-2.34%) helped: 6522 HURT: 35 GAINED: 6 Signed-off-by: Kenneth Graunke Reviewed-by: Connor Abbott Reviewed-by: Matt Turner Reviewed-by: Eric Anholt ------------------------------------------------------------ I can also confirm that reverting that commit on top of recent HEAD (4deca127) fixes the issue. I can attach R600_DEBUG=ps,gs,vs output from the offending commit and its parent if you think comparing them is of any use. -- You are receiving this mail because: You are the assignee for the bug. --1428529942.d40D87321.26187 Date: Wed, 8 Apr 2015 21:52:22 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 89944
What Removed Added
CC   kenneth@whitecape.org

Comment # 3 on bug 89944 from
I bisected this down to this commit:

------------------------------------------------------------
commit 30f51f1a1a70bc838d5bed449daff0dd9f2e8ef2
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Wed Oct 22 20:48:21 2014 -0700

    glsl: Optimize "if (cond) discard;" to a conditional discard.               

    st_glsl_to_tgsi and ir_to_mesa have handled conditional discards for a      
    long time; the previous patch added that capability to i965.                

    i965 (Haswell) shader-db stats:                                             

    Without NIR:                                                                
    total instructions in shared programs: 5792133 -> 5776360 (-0.27%)          
    instructions in affected programs:     737585 -> 721812 (-2.14%)            
    helped:                                6300                                 
    HURT:                                  68                                   
    GAINED:                                2                                    

    With NIR:                                                                   
    total instructions in shared programs: 5787538 -> 5769569 (-0.31%)          
    instructions in affected programs:     767843 -> 749874 (-2.34%)
    helped:                                6522
    HURT:                                  35
    GAINED:                                6

    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Connor Abbott <cwabbott0@gmail.com>
    Reviewed-by: Matt Turner <mattst88@gmail.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
------------------------------------------------------------

I can also confirm that reverting that commit on top of recent HEAD (4deca127)
fixes the issue.

I can attach R600_DEBUG=ps,gs,vs output from the offending commit and its
parent if you think comparing them is of any use.


You are receiving this mail because:
  • You are the assignee for the bug.
--1428529942.d40D87321.26187-- --===============0120509798== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0120509798==--