From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass Date: Wed, 29 Apr 2015 09:48:51 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2112800873==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 63BBF7A013 for ; Wed, 29 Apr 2015 02:48:51 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2112800873== Content-Type: multipart/alternative; boundary="1430300931.d10551.31096"; charset="UTF-8" --1430300931.d10551.31096 Date: Wed, 29 Apr 2015 09:48:51 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=90056 --- Comment #13 from Andy Furniss --- (In reply to Tom Stellard from comment #12) > (In reply to Andy Furniss from comment #10) > > (In reply to Grigori Goronzy from comment #9) > > > Created attachment 115409 [details] [review] [review] [review] > > > Full shader > > > > > > That does not help either. Seems to break the SSA somehow. Full shader that > > > triggers the bug attached. > > > > > > The patch I posted earlier help with the the reduced testcase, but not with > > > the full shader. Both undef incoming values in phi nodes and undef branch > > > conditions cause problems in different ways. > > > > With the second patch + valley I get - > > > > valley_x64: LiveVariables.cpp:114: void > > llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &, > > llvm::MachineBasicBlock *, llvm::MachineBasicBlock *, > > std::vector &): Assertion `MBB != &MF->front() && > > "Can't find reaching def for virtreg"' failed. > > Did test with only the patch from comment #8 or did you test with both > patches? Just #8 but I just tried with both and get the same fail. -- You are receiving this mail because: You are the assignee for the bug. --1430300931.d10551.31096 Date: Wed, 29 Apr 2015 09:48:51 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 13 on bug 90056 from 
(In reply to Tom Stellard from comment #12)
> (In reply to Andy Furniss from comment #10)
> > (In reply to Grigori Goronzy from comment #9)
> > > Created attachment 115409 [details] [review] [review] [review] [review]
> > > Full shader
> > > 
> > > That does not help either. Seems to break the SSA somehow. Full shader that
> > > triggers the bug attached.
> > > 
> > > The patch I posted earlier help with the the reduced testcase, but not with
> > > the full shader. Both undef incoming values in phi nodes and undef branch
> > > conditions cause problems in different ways.
> > 
> > With the second patch + valley I get -
> > 
> > valley_x64: LiveVariables.cpp:114: void
> > llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &,
> > llvm::MachineBasicBlock *, llvm::MachineBasicBlock *,
> > std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() &&
> > "Can't find reaching def for virtreg"' failed.
> 
> Did test with only the patch from comment #8 or did you test with both
> patches?

Just #8 but I just tried with both and get the same fail.

You are receiving this mail because:
  • You are the assignee for the bug.
--1430300931.d10551.31096-- --===============2112800873== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============2112800873==--