From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 90537] radeonsi bo/va conflict on RADEON_GEM_VA (rscreen->ws->buffer_from_handle returns NULL) Date: Thu, 21 May 2015 20:09:39 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1777945469==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 487CD6E9D0 for ; Thu, 21 May 2015 13:09:39 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1777945469== Content-Type: multipart/alternative; boundary="1432238979.acc83a0.22190"; charset="UTF-8" --1432238979.acc83a0.22190 Date: Thu, 21 May 2015 20:09:39 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=90537 --- Comment #5 from pstglia@gmail.com --- Hi Christian, > Watch out for memory leaks as well. > > When mesa drops the last reference to the BO by closing it's handle the VA > mapping should go away automatically. That's the reason why it works for X > and EGL. > > What you see here is that you manually need to remove the VA mapping because > there is still a reference to the BO outside of mesa. > > Could be intentional, but could be a bug as well. Thanks for pointing this out. Just a question: In this case (bug on application on mapping BOs/VAs) shouldn't we have a crash using other drivers? With r600g we don't have this problem (tested with an ARUBA A10 5800K), just on radeonsi (at least on the tests I performed, which are basically running "Antutu Benchmark" and some other apps). However r600g/other drivers/hardwares can handle this in a different manner of course, which could explain why we don't experience this on other hardwares. > > Anyway Michels patch is clearly a good idea. I've uploaded an testing Android-x86 ISO with Michel patch applied. It's using Lollipop (5.1), Mesa 10.5.4, Kernel 4.0.3 and LLVM 3.5svn (AOSP). It's also enabled for radeonsi (this is the main purpose). In case anyone wants to test it on a radeonsi hardware, here's the link: https://drive.google.com/file/d/0Bx12U5yGNcQCRWdoWWtNdC0weW8/view?usp=sharing Thank you all! pstglia -- You are receiving this mail because: You are the assignee for the bug. --1432238979.acc83a0.22190 Date: Thu, 21 May 2015 20:09:39 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 5 on bug 90537 from 
Hi Christian,

> Watch out for memory leaks as well.
> 
> When mesa drops the last reference to the BO by closing it's handle the VA
> mapping should go away automatically. That's the reason why it works for X
> and EGL.
> 
> What you see here is that you manually need to remove the VA mapping because
> there is still a reference to the BO outside of mesa.
> 
> Could be intentional, but could be a bug as well.

Thanks for pointing this out. Just a question: In this case (bug on application
on mapping BOs/VAs) shouldn't we have a crash using other drivers? With r600g
we don't have this problem (tested with an ARUBA A10 5800K), just on radeonsi
(at least on the tests I performed, which are basically running "Antutu
Benchmark" and some other apps).

However r600g/other drivers/hardwares can handle this in a different manner of
course, which could explain why we don't experience this on other hardwares.

> 
> Anyway Michels patch is clearly a good idea.

I've uploaded an testing Android-x86 ISO with Michel patch applied. It's using
Lollipop (5.1), Mesa 10.5.4, Kernel 4.0.3 and LLVM 3.5svn (AOSP). It's also
enabled for radeonsi (this is the main purpose). In case anyone wants to test
it on a radeonsi hardware, here's the link:
https://drive.google.com/file/d/0Bx12U5yGNcQCRWdoWWtNdC0weW8/view?usp=sharing

Thank you all!

pstglia

You are receiving this mail because:
  • You are the assignee for the bug.
--1432238979.acc83a0.22190-- --===============1777945469== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1777945469==--