From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api Date: Mon, 22 Jun 2015 17:32:51 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0481448809==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 055386E868 for ; Mon, 22 Jun 2015 10:32:51 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0481448809== Content-Type: multipart/alternative; boundary="1434994370.8d7281.4054"; charset="UTF-8" --1434994370.8d7281.4054 Date: Mon, 22 Jun 2015 17:32:50 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=91015 --- Comment #3 from Ian Romanick --- The following two piglit commits are probably necessary: commit 49e326474d5ed487d04ff6bef1efae376e4a2492 Author: Eduardo Lima Mitev Date: Mon Feb 16 11:10:30 2015 +0100 arb_occlusion_query2: Checks that query obj passed to glBeginQuery matches target From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94: "[...] if id is the name of an existing query object whose type does not match target, [...] the error INVALID_OPERATION is generated." Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS QUERIES", page 82. This patch adds a check for this situation. Reviewed-by: Ian Romanick commit 0eff6819639d8c84c98f8fa0bd0b254a69aead60 Author: Eduardo Lima Mitev Date: Sat Feb 14 13:29:52 2015 +0100 arb_occlusion_query2: expect an error when target mismatch in glBeginQuery() From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94: "[...] if id is the name of an existing query object whose type does not match target, [...] the error INVALID_OPERATION is generated." Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS QUERIES", page 82. Hence, trying to call BeginQuery on a query object which has already been bound to a different target should return GL_INVALID_OPERATION. Reviewed-by: Ian Romanick -- You are receiving this mail because: You are the assignee for the bug. --1434994370.8d7281.4054 Date: Mon, 22 Jun 2015 17:32:50 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 3 on bug 91015 from
The following two piglit commits are probably necessary:

commit 49e326474d5ed487d04ff6bef1efae376e4a2492
Author: Eduardo Lima Mitev <elima@igalia.com>
Date:   Mon Feb 16 11:10:30 2015 +0100

    arb_occlusion_query2: Checks that query obj passed to glBeginQuery matches
target

    From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94:

        "[...] if id is the name of an existing query object whose type does
not
         match target, [...] the error INVALID_OPERATION is generated."

    Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13.
    ASYNCHRONOUS QUERIES", page 82.

    This patch adds a check for this situation.

    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

commit 0eff6819639d8c84c98f8fa0bd0b254a69aead60
Author: Eduardo Lima Mitev <elima@igalia.com>
Date:   Sat Feb 14 13:29:52 2015 +0100

    arb_occlusion_query2: expect an error when target mismatch in
glBeginQuery()

    From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94:

        "[...] if id is the name of an existing query object whose type does
not
         match target, [...] the error INVALID_OPERATION is generated."

    Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13.
    ASYNCHRONOUS QUERIES", page 82.

    Hence, trying to call BeginQuery on a query object which has already
    been bound to a different target should return GL_INVALID_OPERATION.

    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>


You are receiving this mail because:
  • You are the assignee for the bug.
--1434994370.8d7281.4054-- --===============0481448809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0481448809==--