From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91461] gl_TessLevel* writes have no effect for all but the last TCS invocation Date: Sat, 25 Jul 2015 14:33:27 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0711870440==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 371256E14E for ; Sat, 25 Jul 2015 07:33:27 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0711870440== Content-Type: multipart/alternative; boundary="1437834807.8fBe85d50.27379"; charset="UTF-8" --1437834807.8fBe85d50.27379 Date: Sat, 25 Jul 2015 14:33:27 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=91461 Bug ID: 91461 Summary: gl_TessLevel* writes have no effect for all but the last TCS invocation Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: daniel@constexpr.org QA Contact: dri-devel@lists.freedesktop.org The tessellator ignores all writes to gl_TessLevelInner and gl_TessLevelOuter by the tessellation control shader except except those done by the last TCS invocation (gl_InvocationID == patch output vertices - 1). This results in no primitives being generated unless all entries of gl_TessLevelOuter are written in that invocation (the 'initial' values seem to be 0 for gl_TessLevelOuter and 1 for gl_TessLevelInner). Additionally, barrier() does not synchronize changes to the gl_TessLevel* between TCS invocations. Neither of these problems can be reproduced with user-defined 'patch out' variables - writes by any TCS invocation are visible in the evaluation shader and barrier() makes them visible to the other TCS invocations. GPU: Radeon HD 7950 (TAHITI) Mesa: 10.7.0-devel (git-9deb614) LLVM: r243203 -- You are receiving this mail because: You are the assignee for the bug. --1437834807.8fBe85d50.27379 Date: Sat, 25 Jul 2015 14:33:27 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"
Bug ID 91461
Summary gl_TessLevel* writes have no effect for all but the last TCS invocation
Product Mesa
Version git
Hardware Other
OS All
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter daniel@constexpr.org
QA Contact dri-devel@lists.freedesktop.org

The tessellator ignores all writes to gl_TessLevelInner and gl_TessLevelOuter
by the tessellation control shader except except those done by the last TCS
invocation (gl_InvocationID == patch output vertices - 1).

This results in no primitives being generated unless all entries of
gl_TessLevelOuter are written in that invocation (the 'initial' values seem to
be 0 for gl_TessLevelOuter and 1 for gl_TessLevelInner).

Additionally, barrier() does not synchronize changes to the gl_TessLevel*
between TCS invocations.

Neither of these problems can be reproduced with user-defined 'patch out'
variables - writes by any TCS invocation are visible in the evaluation shader
and barrier() makes them visible to the other TCS invocations.

GPU: Radeon HD 7950 (TAHITI)
Mesa: 10.7.0-devel (git-9deb614)
LLVM: r243203


You are receiving this mail because:
  • You are the assignee for the bug.
--1437834807.8fBe85d50.27379-- --===============0711870440== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0711870440==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91461] gl_TessLevel* writes have no effect for all but the last TCS invocation Date: Sat, 25 Jul 2015 14:34:24 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1872399455==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D1366E250 for ; Sat, 25 Jul 2015 07:34:24 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1872399455== Content-Type: multipart/alternative; boundary="1437834864.1a82aee0.27545"; charset="UTF-8" --1437834864.1a82aee0.27545 Date: Sat, 25 Jul 2015 14:34:24 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=91461 --- Comment #1 from Daniel Scharrer --- Created attachment 117373 --> https://bugs.freedesktop.org/attachment.cgi?id=117373&action=edit Tessellation test case I have attached a test case for this. It can be compiled and run using: $ sh tessellation.cpp Use the arrow keys to change which TCS invocation writes to gl_TessLevel* (or use space/enter to toggle between the first and the last). It should display a yellow grid no matter what TCS invocation is selected but instead displays a green grid for invocation 3 and nothing for all other invocations. -- You are receiving this mail because: You are the assignee for the bug. --1437834864.1a82aee0.27545 Date: Sat, 25 Jul 2015 14:34:24 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 1 on bug 91461 from
Created attachment 117373 [details]
Tessellation test case

I have attached a test case for this. It can be compiled and run using:
 $ sh tessellation.cpp

Use the arrow keys to change which TCS invocation writes to gl_TessLevel* (or
use space/enter to toggle between the first and the last).

It should display a yellow grid no matter what TCS invocation is selected but
instead displays a green grid for invocation 3 and nothing for all other
invocations.


You are receiving this mail because:
  • You are the assignee for the bug.
--1437834864.1a82aee0.27545-- --===============1872399455== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1872399455==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91461] gl_TessLevel* writes have no effect for all but the last TCS invocation Date: Mon, 03 Aug 2015 14:11:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0631941675==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 3428F6E5E0 for ; Mon, 3 Aug 2015 07:11:36 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0631941675== Content-Type: multipart/alternative; boundary="1438611096.25Fa8DDc0.27979"; charset="UTF-8" --1438611096.25Fa8DDc0.27979 Date: Mon, 3 Aug 2015 14:11:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=91461 --- Comment #2 from Daniel Scharrer --- I can confirm that the patch "radeonsi: before storing tess levels, load them from LDS instead of temporary" on the mailing list fixes the issue. -- You are receiving this mail because: You are the assignee for the bug. --1438611096.25Fa8DDc0.27979 Date: Mon, 3 Aug 2015 14:11:36 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 2 on bug 91461 from
I can confirm that the patch "radeonsi: before storing tess levels, load them
from LDS instead of temporary" on the mailing list fixes the issue.


You are receiving this mail because:
  • You are the assignee for the bug.
--1438611096.25Fa8DDc0.27979-- --===============0631941675== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0631941675==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91461] gl_TessLevel* writes have no effect for all but the last TCS invocation Date: Thu, 06 Aug 2015 18:51:28 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0929879102==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A44E6EC42 for ; Thu, 6 Aug 2015 11:51:28 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0929879102== Content-Type: multipart/alternative; boundary="1438887088.e65272F61.10278"; charset="UTF-8" --1438887088.e65272F61.10278 Date: Thu, 6 Aug 2015 18:51:27 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D91461 Marek Ol=C5=A1=C3=A1k changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Marek Ol=C5=A1=C3=A1k --- Fixed by 60159bcfc66a067b50da06f5cabfa20d72e89. Closing. --=20 You are receiving this mail because: You are the assignee for the bug. --1438887088.e65272F61.10278 Date: Thu, 6 Aug 2015 18:51:28 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable = Marek Ol=C5=A1=C3=A1k changed bug 91461<= /a>
What Removed Added
Status NEW RESOLVED
Resolution --- FIXED

Comment= # 3 on bug 91461<= /a> from Marek Ol=C5=A1=C3=A1k
Fixed by 60159bcfc66a067b50da06f5cabfa20d72e89. Closing.


You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1438887088.e65272F61.10278-- --===============0929879102== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0929879102==--