From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91985] [regression, bisected] FTBFS with commit f9caabe8f1: R600_UCP_CONST_BUFFER is undefined Date: Sat, 12 Sep 2015 08:25:48 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1154919590==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 029E46EDBC for ; Sat, 12 Sep 2015 01:25:48 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1154919590== Content-Type: multipart/alternative; boundary="1442046347.aAa62FE2.15777"; charset="UTF-8" --1442046347.aAa62FE2.15777 Date: Sat, 12 Sep 2015 08:25:47 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D91985 --- Comment #3 from Kai --- (In reply to Ilia Mirkin from comment #1) > Seems more likely that the culprit is >=20 > From f9caabe8f1bff86d19b53d9ecba5c72b238d9e23 Mon Sep 17 00:00:00 2001 > From: Dave Airlie > Date: Fri, 11 Sep 2015 04:43:53 +0100 > Subject: r600g: lower number of driver const buffers >=20 > I'm going to want a driver constant buffer for tess to coordinate > LDS storage, so before I go tackling that I decided to merge the > clip/samplepos and texture info buffers into one. So I can steal > the spare one. >=20 > This creates a single constant buffer between the two, with > clip/samplepos taking up a reserved 128 bytes at the start. >=20 > Reviewed-by: Edward O'Callaghan > Reviewed-by: Glenn Kennard > Signed-off-by: Dave Airlie >=20 > than a commit from 2013... Yes, I had =E2=80=93 after looking with git blame at r600_llvm.c =E2=80=93 = the wrong commit in my clipboard and worked with that. Since both start with f9 I didn't notice. Sorry. --=20 You are receiving this mail because: You are the assignee for the bug. --1442046347.aAa62FE2.15777 Date: Sat, 12 Sep 2015 08:25:47 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Comment= # 3 on bug 91985<= /a> from Kai 
(In reply to Ilia Mirkin from comment #1)
> Seems more likely that the culprit is
>=20
> From f9caabe8f1bff86d19b53d9ecba5c72b238d9e23 Mon Sep 17 00:00:00 2001
> From: Dave Airlie <airlie=
d@redhat.com>
> Date: Fri, 11 Sep 2015 04:43:53 +0100
> Subject: r600g: lower number of driver const buffers
>=20
> I'm going to want a driver constant buffer for tess to coordinate
> LDS storage, so before I go tackling that I decided to merge the
> clip/samplepos and texture info buffers into one. So I can steal
> the spare one.
>=20
> This creates a single constant buffer between the two, with
> clip/samplepos taking up a reserved 128 bytes at the start.
>=20
> Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
> Reviewed-by: Glenn Kennard <glenn.kennard@gmail.com>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
>=20
> than a commit from 2013...

Yes, I had =E2=80=93 after looking with git blame at r600_llvm.c =E2=80=93 =
the wrong commit in
my clipboard and worked with that. Since both start with f9 I didn't notice.
Sorry.

You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1442046347.aAa62FE2.15777-- --===============1154919590== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1154919590==--